Add auto-approve toggle instead of badge

cmoriarty commented

2026-09-29 09:58:45 -04:00

Owner

Now that the auto approve badge is on the graph spine, it has enough room for the toggle to be displayed. Actually, I'd like both the auto-approve AND the show thinking (currently on title bar) to be next to each other on the graph spine. They should also use the same toggle/checkbox, whichever looks better.

cmoriarty referenced this issue

2026-10-03 09:55:19 -04:00

A failing test suite passes agent.test.unit: its completion only checks that the report exists #137

cmoriarty referenced this issue from a commit

2026-10-03 11:01:36 -04:00

Propose spine-switches (#113) [skip ci]

cmoriarty referenced this issue from a commit

2026-10-03 11:01:36 -04:00

feat(ui): auto-approve and show thinking are switches side by side at the top of the spine (#113)

cmoriarty commented

2026-10-03 11:06:41 -04:00

Author

Owner

Shipped and live on production (9ae119c, deployed 2026-10-03).

The spine now opens with one row of two switches, side by side and drawn alike: auto-approve and show thinking. The row is there whether auto-approve is on or off, above the SETUP band.
auto-approve saves the setting when it is switched (the same auto_approve field the Settings page saves, sent on its own) and follows the setting, so a save from another tab or the Settings page moves it. It is off and disabled until the settings have been read, it keeps keyboard focus while it saves, and a refused save puts it back and says Nothing was saved — <why>. On, it is drawn in the auto-approve colour, which no run or step state uses.
show thinking left the run bar. It is still this browser's own choice, h still toggles it, and the Settings default still applies to a browser that has not chosen. The run bar's stepper row now ends with its last phase, and the phone's spine shows both switches (the bar showed neither there).
Not added: a key for auto-approve, and a confirmation when switching it on. Switching it on answers open merge gates at once, as saving it from Settings already does; if you want a confirmation first it is a small addition.

Checked with Playwright against the fixture (1440 px, 1024 px and a phone width; a click, Tab and Space; a refused save; the disabled state before the settings arrive), and on production in the deployed console: the row holds both switches side by side, the run bar holds none, auto-approve reads on (production's own setting, never clicked), a click on show thinking turns it off and h turns it back on. The fast and full lanes pass.

Change record: openspec/changes/archive/2026-10-03-spine-switches.

Shipped and live on production (`9ae119c`, deployed 2026-10-03). - The spine now opens with one row of two switches, side by side and drawn alike: **auto-approve** and **show thinking**. The row is there whether auto-approve is on or off, above the SETUP band. - **auto-approve** saves the setting when it is switched (the same `auto_approve` field the Settings page saves, sent on its own) and follows the setting, so a save from another tab or the Settings page moves it. It is off and disabled until the settings have been read, it keeps keyboard focus while it saves, and a refused save puts it back and says `Nothing was saved — <why>`. On, it is drawn in the auto-approve colour, which no run or step state uses. - **show thinking** left the run bar. It is still this browser's own choice, `h` still toggles it, and the Settings default still applies to a browser that has not chosen. The run bar's stepper row now ends with its last phase, and the phone's spine shows both switches (the bar showed neither there). - Not added: a key for auto-approve, and a confirmation when switching it on. Switching it on answers open merge gates at once, as saving it from Settings already does; if you want a confirmation first it is a small addition. Checked with Playwright against the fixture (1440 px, 1024 px and a phone width; a click, Tab and Space; a refused save; the disabled state before the settings arrive), and on production in the deployed console: the row holds both switches side by side, the run bar holds none, auto-approve reads on (production's own setting, never clicked), a click on show thinking turns it off and `h` turns it back on. The fast and full lanes pass. Change record: `openspec/changes/archive/2026-10-03-spine-switches`.

cmoriarty closed this issue

2026-10-03 11:06:41 -04:00

cmoriarty referenced this issue from a commit

2026-10-03 11:10:21 -04:00

Archive six changes (#73, #113, #114, #125, #126, #127) [skip ci]

Rows
Columns

Add auto-approve toggle instead of badge #113