Run 37's code review failed because its one finding was about a whole file and gave "line": 0, while the schema wanted a line of at least 1. The node says mediate: missing, which left every report that was present to a person, so nothing tried it again and the run failed after 2 h 43 min.

Now a code-review finding may have line 0 or null, the code review's prompt asks for null, and the pull request names such a finding by its file alone. More generally, on the code review and the browser check a report that fails its schema only on its form (not JSON, a field missing, a wrong type or value) is tried again, briefed with each error the schema found. A well-formed fail, an unfixed blocking finding or failing tests still stop the run for a person.

Fixed by `retry-malformed-reports` (one of the #121 changes), deployed in `03b6fe6`. Run 37's code review failed because its one finding was about a whole file and gave `"line": 0`, while the schema wanted a line of at least 1. The node says `mediate: missing`, which left every report that was present to a person, so nothing tried it again and the run failed after 2 h 43 min. Now a code-review finding may have `line` 0 or null, the code review's prompt asks for null, and the pull request names such a finding by its file alone. More generally, on the code review and the browser check a report that fails its schema only on its form (not JSON, a field missing, a wrong type or value) is tried again, briefed with each error the schema found. A well-formed `fail`, an unfixed blocking finding or failing tests still stop the run for a person.

cmoriarty closed this issue

2026-10-02 16:39:38 -04:00

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cmoriarty/braid#122

No description provided.

Rows
Columns