cmoriarty/braid
1
0
Fork 0
Code Issues 15 Pull requests Projects Releases Packages 1 Wiki Activity Actions

A solo run's spine draws its review loop as six bands, every round of it from the start #153

New issue
Closed
opened 2026-10-06 01:48:07 -04:00 by cmoriarty · 1 comment
cmoriarty commented 2026-10-06 01:48:07 -04:00
Owner
Copy link

What happens (#151's solo pipeline, a new run)

The spine draws the proposal's review loop as alternating bands:

  • HUMAN: agent.review-proposal.solo;
  • REVIEW: openspec.revise.solo;
  • PULL REQUEST: git.commit.revision.solo;
  • then the same three again for round 2, and a third HUMAN band for .r3.

All of them are drawn before anything has asked for a revision.

Why

  • The console groups a step into a phase by its node id. It does not know solo's ids:
    • human.review-proposal.solo falls back to its first segment, human, which becomes a band of its own;
    • git.commit.revision.solo is grouped by commit, under PULL REQUEST.
  • A later round is hidden until it starts, but only for ids that end in .r2 or .r3 and are known review steps. openspec.revise.solo and its commit have no suffix, and none of solo's ids are on the list.

Proposal

  • Solo's gate, revise and revision commit belong to the REVIEW band.
  • The revise after gate 1, its commit and gate 2 are round 2. The revise after gate 2, its commit and gate 3 are round 3.
  • Each round is drawn only once it starts, as thorough's review rounds are. A clean solo run then shows one REVIEW band with one gate.
**What happens** (#151's `solo` pipeline, a new run) The spine draws the proposal's review loop as alternating bands: - **HUMAN:** `agent.review-proposal.solo`; - **REVIEW:** `openspec.revise.solo`; - **PULL REQUEST:** `git.commit.revision.solo`; - then the same three again for round 2, and a third HUMAN band for `.r3`. All of them are drawn before anything has asked for a revision. **Why** - The console groups a step into a phase by its node id. It does not know solo's ids: - `human.review-proposal.solo` falls back to its first segment, `human`, which becomes a band of its own; - `git.commit.revision.solo` is grouped by `commit`, under PULL REQUEST. - A later round is hidden until it starts, but only for ids that end in `.r2` or `.r3` and are known review steps. `openspec.revise.solo` and its commit have no suffix, and none of solo's ids are on the list. **Proposal** - Solo's gate, revise and revision commit belong to the REVIEW band. - The revise after gate 1, its commit and gate 2 are round 2. The revise after gate 2, its commit and gate 3 are round 3. - Each round is drawn only once it starts, as `thorough`'s review rounds are. A clean solo run then shows one REVIEW band with one gate.
cmoriarty commented 2026-10-06 02:06:15 -04:00
Author
Owner
Copy link

Fixed in fab99fb, live, archived as solo-review-band.

  • Solo's proposal gates, revise steps and revision commits are drawn in the REVIEW band.
  • The revise after a gate, its commit and the next gate are a round. Each round is drawn only once one of its steps starts, as thorough's review rounds are.
  • A clean solo run shows one REVIEW band holding one gate.
  • Verified with vitest and a Playwright spec on a fixture solo run; the spec fails with the fix reverted.
  • Also checked in a real browser on a simulated run whose first gate asked for changes. Its REVIEW band reads 4/4 (gate, revise, commit, gate 2), with no round 3.
Fixed in fab99fb, live, archived as `solo-review-band`. - Solo's proposal gates, revise steps and revision commits are drawn in the REVIEW band. - The revise after a gate, its commit and the next gate are a round. Each round is drawn only once one of its steps starts, as `thorough`'s review rounds are. - A clean solo run shows one REVIEW band holding one gate. - Verified with vitest and a Playwright spec on a fixture solo run; the spec fails with the fix reverted. - Also checked in a real browser on a simulated run whose first gate asked for changes. Its REVIEW band reads 4/4 (gate, revise, commit, gate 2), with no round 3.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
archive/prefect-kestra-experiments
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cmoriarty/braid#153
No description provided.