Browser specs: the page-per-assertion files share their set-up (new-run-wizard, run-tabs, settings) #229
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Tier 2 of the test-suite speed-up (#227). Summed test time in the browser step is 1,405 s; three files pay for a page load and a wizard walk per tiny assertion: new-run-wizard.spec.ts (34 tests, 159 s), run-tabs.spec.ts (23, 128 s), settings.spec.ts (24, 119 s). Twenty-three tests take 10 s or more (388 s together), led by
Complete the project begins the first item…at 42.8 s.Proposal: in each of those files, group the assertions that read one state of the page into one test or a
describewith a sharedbeforeAllpage where the state is not mutated; replace fixedwaitForTimeoutsleeps (49 across the suite) with waits on the condition; and look at the five tests over 20 s one by one. The spec tags (// spec: …) stay on each assertion group so the scenario coverage count does not change. Measure the file times before and after.Closing on the measurement rather than a change. Once each worker had its own fixture (#228), the page-per-assertion files fell by themselves:
new-run-wizard159 s to 23 s,settings119 s to 34 s,run-tabs128 s to 47 s; summed test time 1,405 s to 542 s. Their slowness was the shared fixture, not their structure. The seven tests still over 10 s each measure a window (layout-stability,spine-activity,update-notice) and should. So no test is regrouped and no sleep is replaced.