Auto-approve holds every Sonnet proposal review for a person #244
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
With auto-approve on,
human.review-proposalstill waits for a person. The log says the reviewers "answered in under a minute without reading the change".Why that's wrong
Cost
38.8 min of waiting in the pinball test.
Also
While it's held, the console labels it
agent.review-proposaland shows "waiting on you". A gate held for a person should show as a human step, with the reason.Fix
quick_no_readswhen the change was in the prompt. Keep the guard for a reviewer with no findings and no reasoning.Done when
With auto-approve on, a fast Sonnet review with real findings is approved on its own.
Where to look:
auto_holdandlens_flagsinsrc/osf/pipeline/review.py.From the Braid vs Claude Code pinball test, 2026-10-27 (runs 110–120).
Auto-approve holds Sonnet's proposal reviews: lenses served the change are flagged as not reading itto Auto-approve holds every Sonnet proposal review for a personWhat shipped
osf.gate.heldwith the reason (schema 18). The console then names the stephuman., and the gate card (or a review's decision panel) says why.Tests
tests/pipeline/test_review.py,tests/engine/test_auto_approve.py,ui/src/lib/gateText.test.ts.Shipped in
5598ddf(OpenSpec changeauto-approve-reviews-and-gate-words, archived).