Proposal review: act on the findings, or run fewer reviewers #256
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
Four reviewers read every proposal. In 9 runs they raised 167 findings: 1 blocking, 124 should-fix and 42 notes. Only the blocking one changed anything (a real bug, in run 115). The should-fix findings were dropped.
What we want (one of)
Done when
Review findings either change the proposal, or stop being made.
From the Braid vs Claude Code pinball test, 2026-10-27 (runs 110–120).
Correction first
Should-fix findings were not dropped: up to eight already reach the apply and test steps as findings that do not block. But those steps may not edit the change's documents, so findings about a spec (like "about 60 fps" with no tolerance) were fixed nowhere.
What shipped
agent.reviserevises those once, and the gate follows without another round of lenses.Test
tests/pipeline/test_review.py.Shipped in
5598ddf(OpenSpec changeauto-approve-reviews-and-gate-words, archived).