Build steps write tests without spec tags, so round 1 of every fix loop only adds them #271
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
In 6 of the 11 build runs (123–125, 127–129), the fix loop's first round failed on the test lint ("missing
// spec:tag") before the judge ever looked. A fix round added the tags, and the tests ran again. The untagged tests came mostly fromopenspec.apply, which writes unit tests while it builds but never runs the lint.Fix
Done when
Round 1 of a fix loop reaches the judge in a run whose build wrote new tests.
From the #260 re-run's transcripts.
Fixed in #275 (PR #277, live on production). The apply brief asks for a test tagged with each scenario and for
ban-checkon each new test file, and an apply step doesn't finish while its own tests have a blocking lint finding (B1, B2, B6).Run 133: apply ran
ban-checkitself and tagged every scenario (6 of 6), soagent.write-spec-testswas skipped and round 1's lanes passed with no lint finding. The judge didn't run, but only because no UI file changed, not because of the lint. One side effect is filed as #278: rule B7 judges a test by its file name, and the agent renamed a test twice to please it.