A run's tab opens on an empty stage instead of its running step #290
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
Leaving the Inference page by clicking run 136's tab showed an empty stage: "Nothing on the log yet. It appears here the moment the first event is written." Run 136 had a step running. The tab links to
#/run/<id>with no step, and "the selection follows the active step" only moves a selection when the selected step ends, so a run opened with nothing selected stays empty. The message is the transcript's fallback for having no step at all.Fix
A run opened with no step named (its tab, the runs list, a link) selects its active step: the one running, else the one waiting on a person, else the last that ran. A tab could also remember the step last viewed in it.
Done when
Clicking a running run's tab from another page shows its running step's transcript.
From #279, run 136.
Shipped in PR #297 (
1d98b25). Leaving a run for another page forgets that it landed, so its tab opens on its active step again. A browser spec opens a run, goes to Inference, clicks the run's tab and finds the running step selected with its transcript.Verified on production during run 137: from the run, to Inference, and back by the run's tab, the running step was selected again.