The spine splits APPLY in two around script.scenarios #293
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
Run 136's spine shows APPLY 5/5, then SCRIPT 1/1 with
script.scenarios, then APPLY again foragent.write-spec-tests, the code review and the rest.script.scenariosis not in the console's phase map (PHASE_BY_NODEinui/src/components/status.ts), sophaseOffalls back to its first word,script, and the one step splits the apply band in two.Fix
Map
script.scenariostoapply, asscript.dependencies.testsandagent.write-spec-testsare; and have a test check that every built-in node has a phase, so a new step can't fall back silently.Done when
Run 136's steps from
script.dependenciesto the code review sit under one APPLY band, and the test fails for a built-in node without a phase.From #279, run 136.
Shipped in PR #297 (
1d98b25).script.scenariosis in APPLY; so are git-flow's release steps, each in its band (git.flow.release-startsetup,git.flow.pr.openship, tag and back-merge land). A drift test reads the console's phase table and checks every node of every built-in pipeline.Verified on production during run 137:
script.scenariossits inside the APPLY band.