The spine splits APPLY in two around script.scenarios #293

Closed
opened 2026-10-28 19:45:58 -04:00 by cmoriarty · 1 comment
Owner

What happens

Run 136's spine shows APPLY 5/5, then SCRIPT 1/1 with script.scenarios, then APPLY again for agent.write-spec-tests, the code review and the rest. script.scenarios is not in the console's phase map (PHASE_BY_NODE in ui/src/components/status.ts), so phaseOf falls back to its first word, script, and the one step splits the apply band in two.

Fix

Map script.scenarios to apply, as script.dependencies.tests and agent.write-spec-tests are; and have a test check that every built-in node has a phase, so a new step can't fall back silently.

Done when

Run 136's steps from script.dependencies to the code review sit under one APPLY band, and the test fails for a built-in node without a phase.

From #279, run 136.

**What happens** Run 136's spine shows APPLY 5/5, then SCRIPT 1/1 with `script.scenarios`, then APPLY again for `agent.write-spec-tests`, the code review and the rest. `script.scenarios` is not in the console's phase map (`PHASE_BY_NODE` in `ui/src/components/status.ts`), so `phaseOf` falls back to its first word, `script`, and the one step splits the apply band in two. **Fix** Map `script.scenarios` to `apply`, as `script.dependencies.tests` and `agent.write-spec-tests` are; and have a test check that every built-in node has a phase, so a new step can't fall back silently. **Done when** Run 136's steps from `script.dependencies` to the code review sit under one APPLY band, and the test fails for a built-in node without a phase. _From #279, run 136._
Author
Owner

Shipped in PR #297 (1d98b25). script.scenarios is in APPLY; so are git-flow's release steps, each in its band (git.flow.release-start setup, git.flow.pr.open ship, tag and back-merge land). A drift test reads the console's phase table and checks every node of every built-in pipeline.

Verified on production during run 137: script.scenarios sits inside the APPLY band.

Shipped in PR #297 (1d98b25). `script.scenarios` is in APPLY; so are git-flow's release steps, each in its band (`git.flow.release-start` setup, `git.flow.pr.open` ship, tag and back-merge land). A drift test reads the console's phase table and checks every node of every built-in pipeline. Verified on production during run 137: `script.scenarios` sits inside the APPLY band.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid#293
No description provided.