The reconnect backfill test still times out on a loaded CI runner #299
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
test_a_reconnect_backfill_adds_nothing_the_stream_already_deliveredstill fails on CI after #262's one-write fix. It failed on CI run 246 (PR #297,[tool-error]) and on run 249, the push of #297's merge, which overlapped the deploy ([question]and[cut-off]). Each case ran 1.6 s against the 1 s limit; locally they take 0.01 s. The same 1.6 s in three cases on two runs looks like a fixed wait hit on a slow runner, not general slowness. Main's push run is red because of it.Fix
Find the wait the slow path hits (a reconnect or backfill timeout near 1.5 s) and make the test not depend on it. If there is none, mark it medium with a reason.
Done when
Five CI runs in a row pass it, including a push that overlaps a deploy.
Fixed in #300 (merge
12e8c66, live on production).Cause: the runner's disk, not a wait in the code. A small test that creates or closes a SQLite file syncs it to disk, and on a busy runner a sync took a second or more. Moving the reconnect test's store into a fixture only moved the failure: run 252 then failed
test_migrating_twice_changes_nothingat 1.0 s.Fix: the CI job's
/tmp, where every test's files go, is now a 1 GB tmpfs. A first step fails the job if it isn't. The reconnect test also uses the sharedstorefixture now, like every other store test.Done when, met: five runs in a row passed, with the tmpfs check passing in each.
Before the tmpfs, the same 198 tests took 6.1–12.0 s (runs 246, 249, 251, 252).