A web app's scripts in src/ don't count as UI, so changing them gets no Visual check #320
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
The fix loop runs the Visual check only when a UI file changed (
conditions.is_ui_path). That means.html,.css,.tsx,.jsxand the like anywhere, but.jsand.tsonly underui/,web/,frontend/orclient/. Braid's own planned projects build plain-JavaScript web apps with their code insrc/: the Breakout game draws everything fromsrc/render.js. A fix run that changes onlysrc/render.jsorsrc/main.js, such as the colours or the controls, gets no Visual check. Seen 2026-10-29 setting up #269's seeded faults.Fix
Count a script as UI when the project is a web app whose page loads it: a
.js/.tsfile under the folder anindex.htmlscript tag points into, or any script in a project whoseindex.htmlsits at the root. Keep a Node service'ssrc/out.Done when
A fix run on a Vite plain-JavaScript game that changes only
src/render.jsgets a Visual check; one that changes a Node service'ssrc/server.jsdoes not. Tests cover both.Shipped in PR #356 (
c00c62f1, live on production)..js/.mjs/.tsfile counts as UI when it sits under a folder that a rootindex.html's script tags load from, or directly in the root when the page loads from there.tests/engine/test_page_scripts_are_ui.py, real git):src/render.jsgets a Visual check; this fails without the fix;src/server.jsdoes not.