A fix round stuck on the same failure isn't told to try another approach #360
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
When a round fails the same way as the one before it, the next fix round gets the usual brief and forks the same session, so it starts with the same assumptions. If it fails the same way again, the run stops for a person.
Why
GVS5H's loop tells its worker to "fix it or try a different approach". No Braid brief does. It's rare (3 of 19 October runs had two fix rounds), but each time it works, it saves a stop.
Fix
In that case, add to
agent.fix's brief: your last fix didn't change this failure, so say what you assumed, check it, and try a different approach. No new step.Done when
tools/replay.sh) shows the agent trying something else.Where to look:
build_fix_repairinsrc/osf/engine/prompts.py;src/osf/pipeline/fixloop.py.From the Memdoor and GVS5H review, 2026-11-02.
Shipped in PR 362.
A round that failed the same way as the one before it now tells
agent.fix: "Your last fix did not change this failure. Before you edit anything, say what you assumed, check it, and try a different approach." A waived round starts the count again.tests/pipeline/test_fix_stuck_and_visual_gaps.py).fix-stuck-tries-another.agent.fix.r2on a real Free model (reflection/beam-free), 3 of 3 succeeded. Round 1 had only written a note. The replay changed the state itself: "I changedstate.txtfrom "one" to "fixed" sopython3 check.pypasses".