A spec-test step that touches a source file ends the run, with no retry #368
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
Run 170 (Scratch, on Free) failed about 64 minutes in, with 45 steps skipped, because of one word.
agent.write-spec-tests[game-rules]addedexportto a private helper inshared/rules.tsso a test could call it. Thetests-onlycheck failed, and the step was not tried again. Its work was otherwise good: 22 tests for 21 scenarios, one left failing on purpose for a real gap (createGamedoesn't validate player count).Why
The step has
mediate: missing, so a failed check goes to a person unless the report is missing or malformed, or it only left files behind (#150). A source edit in this step goes to a person, and with auto-approve on the run just ends. This isn't specific to Free: any backend's run can end this way.Fix
tests-onlygets one retry, whose brief names the file and says to restore it and test through the public interface.Done when
tests-onlyfailure gets a retry undermediate: missing, and other failed checks still go to a person.Shipped in PR 371.
tests-onlyfails, retries, and tells the agent what it restored.exportincluded.Evidence:
sim/spec-tests-edit-restoredandsim/spec-tests-edit-retry-skippedfailed without the fix and pass with it. The second is why a plain retry wasn't enough: its condition skipped the step with the edit left in.createGamedoesn't reject a bad player count, and it left that test in.The replay tool had a bug of its own, fixed in the same PR: a project on another Playwright failed its dependency step on the image's read-only browsers.