A requirement can ship unbuilt: run 171's animations had a ticked task and no code, and nothing checked them #374
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
Run 171's spec says the client "SHALL animate dealing, the trump flip, cards sliding to center, the trick sweeping to the winner, and a scratch mark", and task 6.3 is ticked. The client has no
@keyframesand no animation library, only threetransitionrules. Nothing caught it:Reduced motion, which passes with no animation at all.web-interface/Animationsandweb-interface/Responsive phone playto the Visual check, but those are requirements' names, not scenarios', sowith_visualdropped them without a word. The check was told six of its eight, and the phone layout was never judged.Fix
.osf/test/visual.jsonthat names a requirement reaches the check as that requirement. One that matches nothing fails the step.SHALL.Done when
A sim: a requirement handed over by name gets a verdict, or the round fails. Findings are on #365.
Shipped in PR #390, production
ddd4b6b.Evidence:
tests/pipeline/test_visual_scenarios.pyand simjudge-requirement-by-name. A Free replay of run 172'sagent.review.combinedraised the new flag, in 1.8 minutes.Not proved: run 171's game was not rebuilt, so the next full run is the first real test of a ticked task with no code behind it.