Save turns itself back on after a settings save #395
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
After a save, the Settings page's Save button turns itself back on with nothing changed, and the next save sends
free_tiers: {}. The journey atoperator.spec.ts:84only passes if it sees the button in the moment before the refetch lands: it failed 5 of 30 times alone at the suite's 4 workers, each on that line.Why
same()comparesfree_tiers, an object, by identity, and every read of the settings brings a new{}.Fix
Compare objects by value.
Done when
A fresh read of the settings leaves the form clean (a unit test), and that journey passes 30 of 30 at 4 workers.
Found while verifying #393.
Fixed in #397, not merged yet, so this stays open until it is.
same()now compares objects by value. A unit test that a fresh read leaves the form clean failed first and passes now. The journey atoperator.spec.ts:84passes 30 of 30 at 4 workers, where it failed 5 of 30.Shipped in #397, merge
3e69aa61.