Save turns itself back on after a settings save #395

Closed
opened 2026-11-05 01:51:12 -05:00 by cmoriarty · 2 comments
Owner

What happens
After a save, the Settings page's Save button turns itself back on with nothing changed, and the next save sends free_tiers: {}. The journey at operator.spec.ts:84 only passes if it sees the button in the moment before the refetch lands: it failed 5 of 30 times alone at the suite's 4 workers, each on that line.

Why
same() compares free_tiers, an object, by identity, and every read of the settings brings a new {}.

Fix
Compare objects by value.

Done when
A fresh read of the settings leaves the form clean (a unit test), and that journey passes 30 of 30 at 4 workers.

Found while verifying #393.

**What happens** After a save, the Settings page's Save button turns itself back on with nothing changed, and the next save sends `free_tiers: {}`. The journey at `operator.spec.ts:84` only passes if it sees the button in the moment before the refetch lands: it failed 5 of 30 times alone at the suite's 4 workers, each on that line. **Why** `same()` compares `free_tiers`, an object, by identity, and every read of the settings brings a new `{}`. **Fix** Compare objects by value. **Done when** A fresh read of the settings leaves the form clean (a unit test), and that journey passes 30 of 30 at 4 workers. *Found while verifying #393.*
Author
Owner

Fixed in #397, not merged yet, so this stays open until it is.

same() now compares objects by value. A unit test that a fresh read leaves the form clean failed first and passes now. The journey at operator.spec.ts:84 passes 30 of 30 at 4 workers, where it failed 5 of 30.

Fixed in #397, not merged yet, so this stays open until it is. `same()` now compares objects by value. A unit test that a fresh read leaves the form clean failed first and passes now. The journey at `operator.spec.ts:84` passes 30 of 30 at 4 workers, where it failed 5 of 30.
Author
Owner

Shipped in #397, merge 3e69aa61.

Shipped in #397, merge 3e69aa61.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid#395
No description provided.