feat(forgejo): the issue's screenshots land in the worktree and the brief names them (#405) #406
Loading…
Reference in a new issue
No description provided.
Delete branch "issue-405-brief-assets"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
An issue's image attachments reached the agent only as markdown links, so a run from a screenshot-only issue worked blind on exactly what the operator showed it (braid#405).
Issue.assetsparses the forge'sassetsarray;download_issue_assetsfetches each image with the token, verifies the bytes (magic bytes, 25 MB cap), and saves it under a deterministic name in.osf/brief-assets/— under.osf/, so it stays out of the PR diff (braid#224).brief_from_issuepoints an embedded screenshot at its saved file ("read it before you plan or write code — the read tool shows you the image") and lists attachments the text never references, so a screenshot-only issue is still a request. The old "cannot view it" wording stays only where the attachments are not wired in.script.briefruns the new best-effortosf.forgejo brief-assetsstep, which says in the brief itself when a named screenshot does not land — the step never fails the run.Verification
./tools/test.shin 22s (485 backend, UI types + vitest, build, 39 browser journeys). 16 new tests, all tagged# issue: braid#405.cmoriarty/scratch-vllm-fp8#6downloaded through the real code path (exact sizes, PNG magic), the brief points each at its file, and one downloaded image rendered in the model context via the read tool — the acceptance criterion.assets, so the step is a no-op.Also
Fixes the rotten
app-chrometag inui/src/components/chrome.test.tsthat had the suite red on main since the requirement was renamed in #391 — the one-line repair is what turns CI green here.Part of #405