Round 2's carry rule is left to the judge, and does not bind #414
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens. run 181's round 2, with two off-main-flow faults fixed in the room and session files, carried 16 of 38 criteria and drove whole games again: 45.6 min.
Fix. Braid computes the list to look at (a criterion whose evidence names a changed file, one the fix note names, one that failed) and tells the judge to carry every other one by id; a whole session only when the session's own evidence names a changed file.
Done when. a sim round 2 with a CSS fix looks at one criterion.
From run 181, the verifying run after #407; the log is
docs/design/measurements/work/run-180/findings.md.Shipped in PR #421 (
ff9381d8), changejudge-round-two-mechanics. Braid computes round N's two lists from the records (fixloop.look_list): look at every criterion that failed, a passed one whose evidence names a changed file, and one the fix note names by id; carry every other passed criterion by id. The brief prints both ("Look at these, from what you see now, with nocarried_from: …" / "Carry these, by id: …"), writes them to.osf/fix/rN/look.json, andfalse_carriesfails a carry of a criterion on the look list. A whole session is named only for a changed file the earlier session evidence named; otherwise "do not". Tests intests/pipeline/test_later_rounds.py(run 181's two off-main-flow faults give a look list of two and carry the rest); simjudge-round-two-css-fixpasses with one criterion to look at and one carried.