The review's scope lens flags the state hook Braid asked for #426

Closed
opened 2026-11-08 03:26:27 -05:00 by cmoriarty · 1 comment
Owner

What happens. Runs 181 and 182's combined review both raised, in the scope lens, "window.__app bridge is not asked for by the brief". The brief's rule asks the proposal for the hook (braid#407), so the finding is wrong on purpose. Both times it was a note, which the revise step leaves alone; a should-fix on the same ground would have the revise step strip the judge's way into the app.

Fix. The review brief's scope lens is told what Braid itself asks of a proposal beside the operator's brief (the state hook, the README, the test command) and that those are in scope by Braid's rule, never a finding.

Done when. A replay of run 182's review step raises no finding about the hook, and the scope lens's brief names Braid's own asks.

From runs 181 and 182 (braid#425).

**What happens.** Runs 181 and 182's combined review both raised, in the scope lens, "`window.__app` bridge is not asked for by the brief". The brief's rule asks the proposal for the hook (braid#407), so the finding is wrong on purpose. Both times it was a note, which the revise step leaves alone; a `should-fix` on the same ground would have the revise step strip the judge's way into the app. **Fix.** The review brief's scope lens is told what Braid itself asks of a proposal beside the operator's brief (the state hook, the README, the test command) and that those are in scope by Braid's rule, never a finding. **Done when.** A replay of run 182's review step raises no finding about the hook, and the scope lens's brief names Braid's own asks. From runs 181 and 182 (braid#425).
Author
Owner

Shipped in PR #437 (merged 6a8ee372), archived in PR #438 (review-briefs-after-run-182). The scope lens's question now says: "Braid itself asks every change for a README, a unit test command and, for a page a person acts on, its state and actions on window.__app: those are in scope by Braid's rule, never a finding."

Evidence: tests/engine/test_combined_review.py asserts the combined brief's scope lens carries the sentence; ./tools/test.sh green. Not done: the replay of run 182's review step; the next Scratch run shows whether the hook draws a finding.

**Shipped in PR #437 (merged 6a8ee372), archived in PR #438 (`review-briefs-after-run-182`).** The scope lens's question now says: "Braid itself asks every change for a README, a unit test command and, for a page a person acts on, its state and actions on `window.__app`: those are in scope by Braid's rule, never a finding." Evidence: `tests/engine/test_combined_review.py` asserts the combined brief's scope lens carries the sentence; `./tools/test.sh` green. Not done: the replay of run 182's review step; the next Scratch run shows whether the hook draws a finding.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid#426
No description provided.