The judge is told never to await the server under a paused clock #429
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens. Run 182's judge read in its brief that Braid's clock, paused, holds what the server pushes (braid#415), and used it: "pause the clock (which holds the server's broadcast), fire start, then step the clock". Its page script then awaited the server's reply, which the pause itself was holding. Twice (attempts 1 and 4) the script sat until the watchdog ended the attempt after 1,200 s: about 50 minutes of judging lost (braid#425, findings 14 and 17). PR #428 made such a script fail at 180 s instead of never; it still costs a turn and teaches nothing.
Fix. The probe text in the judge's and
browser's briefs says, in one sentence, that while the clock is paused nothing from the server reaches the page, so a script must never await a reply under a pause: start the action, step the clock to the moment wanted, and only then pause, as the motion probe does; or resume before waiting. The motion probe itself already orders it so.Done when. The brief carries the sentence (a test beside the motion-rule test), and a replay of run 182's judge step with the capsule writes no script that awaits under a pause.
From run 182 (braid#425).
Moot if #433 lands: with the page clock gone there is no pause to await under. Leave open until the revert merges, then close with it. The wait cap of #419 stands on its own.
Closed as moot: PR #435 (#433) removed the page clock, so there is no pause for a script to await under. The wait cap of #419 goes ahead on its own in the next batch (change
browser-wait-cap).