The propose brief's example group has no Depends on: line, so the planner leaves it off #430

Closed
opened 2026-11-08 12:30:12 -05:00 by cmoriarty · 3 comments
Owner

What happens. The planner leaves the Depends on: line off task groups. In run 182 five of the review's six should-fix findings were that omission, and run 181's review found the same; each time a revise pass adds the lines. The propose brief states the rule in a sentence, but the worked example of a group heading shows only the Specs: line, so the planner copies the example and misses the rule.

Fix. Put Depends on: in the brief's example group, directly under Specs:, so the shape the planner copies carries both lines.

Done when. A brief test shows the example carries the line, and a scripted replay of run 182's propose step writes a Depends on: line under every group.

From run 182 (braid#425, finding 3).

**What happens.** The planner leaves the `Depends on:` line off task groups. In run 182 five of the review's six should-fix findings were that omission, and run 181's review found the same; each time a revise pass adds the lines. The propose brief states the rule in a sentence, but the worked example of a group heading shows only the `Specs:` line, so the planner copies the example and misses the rule. **Fix.** Put `Depends on:` in the brief's example group, directly under `Specs:`, so the shape the planner copies carries both lines. **Done when.** A brief test shows the example carries the line, and a scripted replay of run 182's propose step writes a `Depends on:` line under every group. From run 182 (braid#425, finding 3).
Author
Owner

Shipped in PR #437 (merged 6a8ee372), archived in PR #438 (depends-on-in-the-example). The tasks brief's example group now shows Depends on: 1 directly under Specs: draft-autosave, and the rule's sentence points at the example.

Evidence: tests/engine/test_tasks_brief_example.py asserts the example's order: heading, Specs:, Depends on:, first task. ./tools/test.sh green. Not done: the replay of run 182's propose step; the next run's review shows whether the five findings recur.

**Shipped in PR #437 (merged 6a8ee372), archived in PR #438 (`depends-on-in-the-example`).** The tasks brief's example group now shows `Depends on: 1` directly under `Specs: draft-autosave`, and the rule's sentence points at the example. Evidence: `tests/engine/test_tasks_brief_example.py` asserts the example's order: heading, `Specs:`, `Depends on:`, first task. `./tools/test.sh` green. Not done: the replay of run 182's propose step; the next run's review shows whether the five findings recur.
Author
Owner

Reopened: the fix landed in a brief the thorough pipeline does not use. Run 183's planner (braid#439, finding 1) wrote 8 groups with no Depends on: and no Specs: line. Its brief is propose-change (build_propose_change in src/osf/engine/prompts.py), which carries _ARTIFACT_RULES["proposal"] and one sentence on tasks; the Specs:/Depends on: rules and the example of PR #437 are in _ARTIFACT_RULES["tasks"], pasted only by the per-artifact openspec-artifact brief. Run 182's groups had Depends on: only because revise added them after the review, and never had Specs:.

Fix. build_propose_change carries the tasks rules (the Specs: and Depends on: bullets with the example) beside the proposal's; the brief test covers that builder. Done when a thorough run's planner writes both lines under every group before the review.

**Reopened: the fix landed in a brief the thorough pipeline does not use.** Run 183's planner (braid#439, finding 1) wrote 8 groups with no `Depends on:` and no `Specs:` line. Its brief is `propose-change` (`build_propose_change` in `src/osf/engine/prompts.py`), which carries `_ARTIFACT_RULES["proposal"]` and one sentence on tasks; the `Specs:`/`Depends on:` rules and the example of PR #437 are in `_ARTIFACT_RULES["tasks"]`, pasted only by the per-artifact `openspec-artifact` brief. Run 182's groups had `Depends on:` only because revise added them after the review, and never had `Specs:`. **Fix.** `build_propose_change` carries the tasks rules (the `Specs:` and `Depends on:` bullets with the example) beside the proposal's; the brief test covers that builder. **Done when** a thorough run's planner writes both lines under every group before the review.
Author
Owner

Fixed in PR 446. The first fix put the example in the rules for the per-artifact tasks step, which the thorough pipeline's planner never receives. The planner's own brief (propose-change) now carries the tasks rules with the example group, its Specs: and its Depends on: line.

A test builds that brief on a worktree shaped like run 183's and asserts the example group holds both lines. Run 183's planner wrote eight groups with neither.

Fixed in PR 446. The first fix put the example in the rules for the per-artifact `tasks` step, which the thorough pipeline's planner never receives. The planner's own brief (`propose-change`) now carries the tasks rules with the example group, its `Specs:` and its `Depends on:` line. A test builds that brief on a worktree shaped like run 183's and asserts the example group holds both lines. Run 183's planner wrote eight groups with neither.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid#430
No description provided.