The propose brief's example group has no Depends on: line, so the planner leaves it off #430
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens. The planner leaves the
Depends on:line off task groups. In run 182 five of the review's six should-fix findings were that omission, and run 181's review found the same; each time a revise pass adds the lines. The propose brief states the rule in a sentence, but the worked example of a group heading shows only theSpecs:line, so the planner copies the example and misses the rule.Fix. Put
Depends on:in the brief's example group, directly underSpecs:, so the shape the planner copies carries both lines.Done when. A brief test shows the example carries the line, and a scripted replay of run 182's propose step writes a
Depends on:line under every group.From run 182 (braid#425, finding 3).
Shipped in PR #437 (merged
6a8ee372), archived in PR #438 (depends-on-in-the-example). The tasks brief's example group now showsDepends on: 1directly underSpecs: draft-autosave, and the rule's sentence points at the example.Evidence:
tests/engine/test_tasks_brief_example.pyasserts the example's order: heading,Specs:,Depends on:, first task../tools/test.shgreen. Not done: the replay of run 182's propose step; the next run's review shows whether the five findings recur.Reopened: the fix landed in a brief the thorough pipeline does not use. Run 183's planner (braid#439, finding 1) wrote 8 groups with no
Depends on:and noSpecs:line. Its brief ispropose-change(build_propose_changeinsrc/osf/engine/prompts.py), which carries_ARTIFACT_RULES["proposal"]and one sentence on tasks; theSpecs:/Depends on:rules and the example of PR #437 are in_ARTIFACT_RULES["tasks"], pasted only by the per-artifactopenspec-artifactbrief. Run 182's groups hadDepends on:only because revise added them after the review, and never hadSpecs:.Fix.
build_propose_changecarries the tasks rules (theSpecs:andDepends on:bullets with the example) beside the proposal's; the brief test covers that builder. Done when a thorough run's planner writes both lines under every group before the review.Fixed in PR 446. The first fix put the example in the rules for the per-artifact
tasksstep, which the thorough pipeline's planner never receives. The planner's own brief (propose-change) now carries the tasks rules with the example group, itsSpecs:and itsDepends on:line.A test builds that brief on a worktree shaped like run 183's and asserts the example group holds both lines. Run 183's planner wrote eight groups with neither.