A hand-over file in the wrong shape counts for nothing instead of failing the scenarios step #440
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens. Run 183's apply wrote
.osf/test/visual.jsonas{"summary": …, "visual": [{"spec", "requirement", "scenario", "reason"}]}and.osf/test/untested.jsonas{"summary": …, "untested": [{"spec", "requirement", "scenarios": […], "reason"}]}. Braid reads{"scenarios": [{"id": "<capability>/<scenario>", "why": …}]}and nothing else, so both files counted for nothing: 49 scenarios uncovered, none left to the Visual check, none untested, no word to anyone. The code review's brief got no untested list; the Visual check is told to judge every uncovered scenario a person could see (braid#439, finding 6).Fix.
script.scenariosfails when either file exists and is not the documented shape (noscenarioslist, or an entry withoutidandwhy), naming the file, what it found and the shape wanted, so the apply (or the fix round) rewrites it; the record carries the error. The brief's line on the shape stays as it is.Done when. A unit test on run 183's two files fails the step with the message; a well-formed file passes as today; a sim scenario with a mis-shaped
visual.jsonshows the step red with the message.From run 183 (braid#439).
Fixed in PR 448, though not as the issue first put it.
What changed. A new completion check,
scenario-lists, on the apply steps and the fix rounds. When either file exists in another shape, the step that wrote it fails its check, with the file, what it holds and the shape Braid reads. The step is tried again in its own session. The round's record carrieshandover_errors.Why not
script.scenariosfailing. A scripted step that fails stops the run for a person, hours in, over a file an agent rewrites in a minute. The apply's session is still there when its own check runs.Evidence from the laptop.
`.osf/test/visual.json` has no `scenarios` list (its keys: `summary`, `visual`)and the same foruntested.json, followed by the shape to write.id, with nowhy, and one that is not an object are each named. A sound file passes, and so does a step that wrote neither.apply-misshaped-handover: the apply's first attempt writes run 183's shape, its check fails with the message, the retry rewrites the file, the Visual check is left the scenario, and the run merges.Not done: a replay of run 183's apply. Scripted, it holds only the step's first session, which ends before the files are written. The next Scratch run is the soak test.