Two sims fail on main: the apply's context alarm never fires #445

Closed
opened 2026-11-08 22:34:10 -05:00 by cmoriarty · 1 comment
Owner

What happens

Two simulated runs fail on main (d4ea96df), and nothing says so, because the sims are a tool and not part of the suite:

  • apply-auto-plentiful
  • apply-group-compacts

Both script an apply turn past its context alarm (380,000 of 400,000) and expect osf.budget.alarm with fresh_session, then a respawn from Braid's note. No alarm is recorded. The step asks the model for a third turn, which the play does not have, and the run never ends.

Either the alarm no longer fires for a continued apply session, or the scenarios describe a path the engine stopped taking (braid#383 changed when a step forks).

Seven more sims failed on main for another reason, a stale play field in the default play's report. That one is fixed with braid#443.

Fix

Find which it is. If the alarm is broken, fix it with a test. If the scenarios are stale, rewrite them to the path production takes.

Done when

./tools/sim.sh passes every scenario on main.

## What happens Two simulated runs fail on `main` (d4ea96df), and nothing says so, because the sims are a tool and not part of the suite: - `apply-auto-plentiful` - `apply-group-compacts` Both script an apply turn past its context alarm (380,000 of 400,000) and expect `osf.budget.alarm` with `fresh_session`, then a respawn from Braid's note. No alarm is recorded. The step asks the model for a third turn, which the play does not have, and the run never ends. Either the alarm no longer fires for a continued apply session, or the scenarios describe a path the engine stopped taking (braid#383 changed when a step forks). Seven more sims failed on `main` for another reason, a stale `play` field in the default play's report. That one is fixed with braid#443. ## Fix Find which it is. If the alarm is broken, fix it with a test. If the scenarios are stale, rewrite them to the path production takes. ## Done when `./tools/sim.sh` passes every scenario on `main`.
Author
Owner

Fixed in PR 460. The engine was right and the scenarios were stale.

Since braid#407 an apply step starts a session of its own (openspec.apply has no fork_session_of), so at its alarm it is compacted in place. apply-group-compacts and apply-auto-plentiful still expected the older move to a fresh session, with their next turns under respawns; the engine compacted, sent its continuation, and the play had no third turn. Both plays now continue in the same session and expect osf.budget.alarm with compact, osf.budget.compacted and no respawn. The spec's scenario "A group's apply step" said the same stale thing and is corrected.

Evidence. Both pass, and python -m osf.sim --all passes all 85 scenarios.

Fixed in PR 460. The engine was right and the scenarios were stale. Since braid#407 an apply step starts a session of its own (`openspec.apply` has no `fork_session_of`), so at its alarm it is compacted in place. `apply-group-compacts` and `apply-auto-plentiful` still expected the older move to a fresh session, with their next turns under `respawns`; the engine compacted, sent its continuation, and the play had no third turn. Both plays now continue in the same session and expect `osf.budget.alarm` with `compact`, `osf.budget.compacted` and no respawn. The spec's scenario "A group's apply step" said the same stale thing and is corrected. **Evidence.** Both pass, and `python -m osf.sim --all` passes all 85 scenarios.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid#445
No description provided.