Run 188 batch: group order, briefs past compaction, review helpers, bug tickets #474
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens: run 188 (the re-run after #471) stressed a big change through eight apply groups. Groups ran out of the order their briefs claimed, compacted agents lost their briefs, the code review ran out of context in 5 minutes, and bugs found along the way were dropped. Findings: braid#467, comment 8154.
Fix: the 17 fixes the owner approved one by one (braid#467, comment 8187):
readerhelpers and less spec text (9); every changed test file named (10). Servers:apptakes a command; Braid stops background commands at step end and does not wait on a serving one (11). B11 catches helper reads (12).Done when: the suite and sims pass, no fixture brief grows, and the next full run is read for each.
Shipped in PR 476 (
d25e101) and PR 477 (f606db1, archive). Production runsf606db1.What landed: the 17 fixes in comment 8187 of braid#467, as listed in the PR. On run 188's real change the code review's brief is 91,787 characters (it was sent 132,626) and names the main test file among the changed tests; group 5's is 82,228 (was 98,300) and says which groups are done. No fixture brief grew.
Evidence:
./tools/test.shgreen; all 87 sims plus the newbugs-found-filed(a noted bug is drafted, auto-approved and filed); the bug gate answered by hand in the console filed its ticket; scripted replays of run 188's code review and group 5 run on the new engine.Deploy note: d25e101's self-check failed on
python-on-path, which readbackend/.venvafter the finished-run tidy (braid#192) had deleted it, a race that predates this change. PR 477 checks.osf/deps.jsoninstead;f606db1deployed.Changes from the plan: the summary's conclusions are marked unconfirmed in the prompt after a compaction (opencode 2 has no compaction-prompt hook); background commands are stopped and their quiet output read through opencode's
/api/shellroutes, which 2.0.30 has but which only a real run will exercise; any failure there falls back to the 30-minute cap.