Run 192 batch: three bugs, and test guidance on clocks and fast browser tests #485
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens: run 192 (findings on braid#484) found three Braid bugs and gaps in the test guidance. The owner decided each fix one at a time.
Fix:
Bugs
readerhelpers: addcode-reviewtoDELEGATION_WHOLE, with a test that builds the real brief without faking the check.tmp, so a group working side by side can reread it after a compaction.Briefs
4. Reword the planner's sentence so running your own browser test is not "running the whole suite", at the same length.
5. In the brief's "The tests you write": no test waits on or times with the real clock. No new lint rule.
6. Research faster browser tests (driving the app by keyboard and its test hooks, headless, reaching a screen without playing through) and add what works to the same section.
7. The requirement limit: the planner's and the repair's briefs say what counts (the text between the heading and the first scenario), including a requirement copied from the main spec. The failure message gives each count, and the help text says the same.
Not done, on the owner's word: checking the hand-over files when they are written; refusing
pkill/killall. Side by side waits until agents run in isolated environments (braid#201, braid#203).Done when: each item has a failing-then-passing test, briefs grow only by the guidance in 5 and 6, and the next run shows the review using
reader.Shipped in PR 486 (merge
f27905f), archived in PR 487 (merged with[skip ci], no redeploy). Production servesf27905fon a new boot.htmlin one test and rendered markup in another, now pass.reader. The test builds the real brief with nothing faked.tmpfolder, so a side-by-side group can reread it after compacting.--listonly loads it.page.clock). A browser test reaches its state through the app's test hook, a seed or a shortcut instead of stepping through the whole flow.osf.spec_lengthto list the long ones.Evidence: each fix has a test that failed before and passes after.
./tools/test.shand./tools/sim.sh --smokepassed on the laptop, and CI passed. The next full run should show no B11 false failures, the code review usingreader, and no wall-clock tests.