Runs 194 and 195: the first batch of fixes #506

Closed
opened 2026-11-12 10:06:32 -05:00 by cmoriarty · 1 comment
Owner

What happens

Runs 194 and 195 (braid#501, braid#505) left findings the owner went through one by one on 2026-11-12. This is the first batch: the small fixes. Helpers that queue, keeping a waiting step warm, the agent documentation and the estimate are their own work.

Fix

  • Unit lane ran one suite of two (195, finding 4): a merge joins the lane commands two groups wrote, and a group that runs side by side is told to write only its own.
  • Shared files in conflict (194, finding 6): the same note says how to add to a file several groups write. Groups applied in turn do not get the note.
  • Several people in one browser check (195, finding 1): the helper is told how to open each person and switch between them.
  • Where things are: the screenshots folder as a real path (194, 3), the browsers' folder (195, 3), the lint's rules (194, 1).
  • "Close the browser first" (194, 2): said in the brief before it is refused. Braid's plugin cannot make the call itself.
  • Guard: Braid's own code is refused in a shell command too (194, 1); a folder under groups/ that is no group's worktree is not called another step's copy (194, 4).
  • Image: fuser and lsof (194, 7).

Done when

./tools/test.sh passes and production runs it.

**What happens** Runs 194 and 195 (braid#501, braid#505) left findings the owner went through one by one on 2026-11-12. This is the first batch: the small fixes. Helpers that queue, keeping a waiting step warm, the agent documentation and the estimate are their own work. **Fix** - **Unit lane ran one suite of two** (195, finding 4): a merge joins the lane commands two groups wrote, and a group that runs side by side is told to write only its own. - **Shared files in conflict** (194, finding 6): the same note says how to add to a file several groups write. Groups applied in turn do not get the note. - **Several people in one browser check** (195, finding 1): the helper is told how to open each person and switch between them. - **Where things are**: the screenshots folder as a real path (194, 3), the browsers' folder (195, 3), the lint's rules (194, 1). - **"Close the browser first"** (194, 2): said in the brief before it is refused. Braid's plugin cannot make the call itself. - **Guard**: Braid's own code is refused in a shell command too (194, 1); a folder under `groups/` that is no group's worktree is not called another step's copy (194, 4). - **Image**: `fuser` and `lsof` (194, 7). **Done when** `./tools/test.sh` passes and production runs it.
Author
Owner

Shipped: pull request 507 (main 7c2c565a, production 7c2c565), archived in pull request 508 (merged with skip ci).

Evidence, on the laptop

  • ./tools/test.sh passes (39 s). The merge test fails without the rule: the run kept uv run pytest backend/tests -q alone; with it the result is uv run pytest backend/tests -q && (cd frontend && npm test).
  • Scenarios: 8 of 8 on the laptop; 6 of 6 in the image with step sandboxes on, parallel-groups and parallel-conflict among them.
  • The guard's table: sed and grep over Braid's package refused, the lint's own command not; groups/screenshots not called another step's copy.

On production: osfd doctor 0 failed, 0 warned; fuser and lsof in the image.

Changed from the review: Braid cannot close the browser for an agent (its plugin does not see the browser tools), so that is a sentence in the brief.

Still to come, as their own work: helpers that queue and a step told its places (195, finding 5), keeping a waiting step warm (195, 2), the agent documentation and taking Braid's package out of the sandbox (194, 1 and 7), and the estimate against what filled the contexts (195, 6).

**Shipped**: pull request 507 (main `7c2c565a`, production `7c2c565`), archived in pull request 508 (merged with skip ci). **Evidence, on the laptop** - `./tools/test.sh` passes (39 s). The merge test fails without the rule: the run kept `uv run pytest backend/tests -q` alone; with it the result is `uv run pytest backend/tests -q && (cd frontend && npm test)`. - Scenarios: 8 of 8 on the laptop; 6 of 6 in the image with step sandboxes on, `parallel-groups` and `parallel-conflict` among them. - The guard's table: `sed` and `grep` over Braid's package refused, the lint's own command not; `groups/screenshots` not called another step's copy. **On production**: `osfd doctor` 0 failed, 0 warned; `fuser` and `lsof` in the image. **Changed from the review**: Braid cannot close the browser for an agent (its plugin does not see the browser tools), so that is a sentence in the brief. **Still to come, as their own work**: helpers that queue and a step told its places (195, finding 5), keeping a waiting step warm (195, 2), the agent documentation and taking Braid's package out of the sandbox (194, 1 and 7), and the estimate against what filled the contexts (195, 6).
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid#506
No description provided.