Ask on a live run leaves an open "Repair" row once the run finishes #547

Closed
opened 2026-11-15 15:21:31 -05:00 by cmoriarty · 1 comment
Owner

What happens

Asking a live run a question leaves a "Repair · 02:17 PM–" row at the foot of the spine after the run succeeds. The row opens the Ask conversation under the name Repair, and its time never ends.

  • Nothing closes an Ask period. announce_repair records osf.repair.opened for Ask too, but _settle_repair only closes runs in _repair_at, and open_repair keeps Ask out of it (braid#223). The period stays open until osfd restarts.
  • The console names any record on a finished run Repair: sessionWords always writes "Repair ·", and helperTab returns Repair for a succeeded run.

Fix

Close the period when the run settles, and record which agent opened it. Name a conversation that was only Ask's "Ask" on a finished run.

Done when

An Ask on a run that then succeeds shows "Ask · start–end" at the spine's foot. A test covers each half, failing before the fix.

**What happens** Asking a live run a question leaves a "Repair · 02:17 PM–" row at the foot of the spine after the run succeeds. The row opens the Ask conversation under the name Repair, and its time never ends. - Nothing closes an Ask period. `announce_repair` records `osf.repair.opened` for Ask too, but `_settle_repair` only closes runs in `_repair_at`, and `open_repair` keeps Ask out of it (braid#223). The period stays open until osfd restarts. - The console names any record on a finished run Repair: `sessionWords` always writes "Repair ·", and `helperTab` returns Repair for a succeeded run. **Fix** Close the period when the run settles, and record which agent opened it. Name a conversation that was only Ask's "Ask" on a finished run. **Done when** An Ask on a run that then succeeds shows "Ask · start–end" at the spine's foot. A test covers each half, failing before the fix.
Author
Owner

osf.repair.opened names its agent. An Ask period closes when its run is no longer live, and Ask going on as Repair closes Ask's period first. The spine's entry and the helper tab read Ask · start–end for a conversation that was only Ask's. Records from before this change read Repair.

Evidence: two backend tests, an Ask on a run that then succeeds and Ask turning into Repair, both failing on the old code, plus vitests for the naming.

Shipped in pull request 550 (merge 3bed64d), change console-fixes-and-session-cap, archived in pull request 551.

`osf.repair.opened` names its agent. An Ask period closes when its run is no longer live, and Ask going on as Repair closes Ask's period first. The spine's entry and the helper tab read `Ask · start–end` for a conversation that was only Ask's. Records from before this change read Repair. Evidence: two backend tests, an Ask on a run that then succeeds and Ask turning into Repair, both failing on the old code, plus vitests for the naming. Shipped in pull request 550 (merge `3bed64d`), change `console-fixes-and-session-cap`, archived in pull request 551.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid#547
No description provided.