Ask on a live run leaves an open "Repair" row once the run finishes #547
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
Asking a live run a question leaves a "Repair · 02:17 PM–" row at the foot of the spine after the run succeeds. The row opens the Ask conversation under the name Repair, and its time never ends.
announce_repairrecordsosf.repair.openedfor Ask too, but_settle_repaironly closes runs in_repair_at, andopen_repairkeeps Ask out of it (braid#223). The period stays open until osfd restarts.sessionWordsalways writes "Repair ·", andhelperTabreturns Repair for a succeeded run.Fix
Close the period when the run settles, and record which agent opened it. Name a conversation that was only Ask's "Ask" on a finished run.
Done when
An Ask on a run that then succeeds shows "Ask · start–end" at the spine's foot. A test covers each half, failing before the fix.
osf.repair.openednames its agent. An Ask period closes when its run is no longer live, and Ask going on as Repair closes Ask's period first. The spine's entry and the helper tab readAsk · start–endfor a conversation that was only Ask's. Records from before this change read Repair.Evidence: two backend tests, an Ask on a run that then succeeds and Ask turning into Repair, both failing on the old code, plus vitests for the naming.
Shipped in pull request 550 (merge
3bed64d), changeconsole-fixes-and-session-cap, archived in pull request 551.