Review gates: the merge gate's proof, the diff and Fix first (slices 2 to 8 of braid#26) #548
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Follow-up to braid#26, whose audit and design stay there. Slice 1, the proposal summary, shipped in braid#537. The phone app is braid#538.
What happens
The merge gate shows a title, branches and a link to the forge. The proof is in Braid's records and never reaches the gate: tests, scenarios with proof, the Visual check's screenshots, the code review's notes. Auto-approve answers every gate, whatever a check says. The diff viewer serves the worktree, not what merges, all in one response.
Fix
Slices 2 to 8 of the design comments on braid#26:
Done when
On a real run, the merge gate leads with its verdict and proof, and the diff shows what merges. Each slice can ship on its own.
Slice 2 shipped in pull request 566 (change
merge-gate-proof-548): the merge gate's proof.When the merge gate opens, Braid joins the last fix round's scenarios by part (a passing test, a look in the browser, left out on purpose with why, or none), the lanes, the Visual check's screenshots and session, the code review's notes and the tasks. It judges six checks: Scenarios with proof, Tests, Seen working, Code review, Tasks and Same code. Same code compares each file the last check saw with what merges, by content. The merge gate's card leads with the verdict, looks first, then the screenshots with the criteria each stands for, the session, the proof by part, the lanes and CI, and the notes left. The gate's answers are where they were. Can merge stays the live read of the pull request.
Read against run 201's real records first: 31 of 32 scenarios proven, 1 left out with its reason, 54 tests in 2 lanes, 10 of 10 looks and a session played, 1 note left of 2.
Left here: slices 3 (now braid#538), 4 to 8.
On production since
19a75bd; the change is archived in pull request 568.