Review gates: the merge gate's proof, the diff and Fix first (slices 2 to 8 of braid#26) #548

Open
opened 2026-11-15 16:33:15 -05:00 by cmoriarty · 1 comment
Owner

Follow-up to braid#26, whose audit and design stay there. Slice 1, the proposal summary, shipped in braid#537. The phone app is braid#538.

What happens

The merge gate shows a title, branches and a link to the forge. The proof is in Braid's records and never reaches the gate: tests, scenarios with proof, the Visual check's screenshots, the code review's notes. Auto-approve answers every gate, whatever a check says. The diff viewer serves the worktree, not what merges, all in one response.

Fix

Slices 2 to 8 of the design comments on braid#26:

  • Merge gate: proof by part, and the Same code, Scope and Tests-it-wrote-were-run checks.
  • Auto-approve stops when a check wants a look.
  • The diff: what merges, files grouped by who wrote them, notes kept on the server, a phone layout.
  • Fix first: a third answer at the merge gate. Try it: serve the run's build for a set time.

Done when

On a real run, the merge gate leads with its verdict and proof, and the diff shows what merges. Each slice can ship on its own.

Follow-up to braid#26, whose audit and design stay there. Slice 1, the proposal summary, shipped in braid#537. The phone app is braid#538. **What happens** The merge gate shows a title, branches and a link to the forge. The proof is in Braid's records and never reaches the gate: tests, scenarios with proof, the Visual check's screenshots, the code review's notes. Auto-approve answers every gate, whatever a check says. The diff viewer serves the worktree, not what merges, all in one response. **Fix** Slices 2 to 8 of the design comments on braid#26: - Merge gate: proof by part, and the Same code, Scope and Tests-it-wrote-were-run checks. - Auto-approve stops when a check wants a look. - The diff: what merges, files grouped by who wrote them, notes kept on the server, a phone layout. - Fix first: a third answer at the merge gate. Try it: serve the run's build for a set time. **Done when** On a real run, the merge gate leads with its verdict and proof, and the diff shows what merges. Each slice can ship on its own.
Author
Owner

Slice 2 shipped in pull request 566 (change merge-gate-proof-548): the merge gate's proof.

When the merge gate opens, Braid joins the last fix round's scenarios by part (a passing test, a look in the browser, left out on purpose with why, or none), the lanes, the Visual check's screenshots and session, the code review's notes and the tasks. It judges six checks: Scenarios with proof, Tests, Seen working, Code review, Tasks and Same code. Same code compares each file the last check saw with what merges, by content. The merge gate's card leads with the verdict, looks first, then the screenshots with the criteria each stands for, the session, the proof by part, the lanes and CI, and the notes left. The gate's answers are where they were. Can merge stays the live read of the pull request.

Read against run 201's real records first: 31 of 32 scenarios proven, 1 left out with its reason, 54 tests in 2 lanes, 10 of 10 looks and a session played, 1 note left of 2.

Left here: slices 3 (now braid#538), 4 to 8.

On production since 19a75bd; the change is archived in pull request 568.

**Slice 2 shipped** in pull request 566 (change `merge-gate-proof-548`): the merge gate's proof. When the merge gate opens, Braid joins the last fix round's scenarios by part (a passing test, a look in the browser, left out on purpose with why, or none), the lanes, the Visual check's screenshots and session, the code review's notes and the tasks. It judges six checks: Scenarios with proof, Tests, Seen working, Code review, Tasks and Same code. Same code compares each file the last check saw with what merges, by content. The merge gate's card leads with the verdict, looks first, then the screenshots with the criteria each stands for, the session, the proof by part, the lanes and CI, and the notes left. The gate's answers are where they were. Can merge stays the live read of the pull request. Read against run 201's real records first: 31 of 32 scenarios proven, 1 left out with its reason, 54 tests in 2 lanes, 10 of 10 looks and a session played, 1 note left of 2. Left here: slices 3 (now braid#538), 4 to 8. On production since 19a75bd; the change is archived in pull request 568.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid#548
No description provided.