Pull requests are too dense for a person to read: review how Braid writes them #570
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
cmoriarty/sports-breaker#200 runs to 1,249 words:
A site row whose opponent is a placeholder ("TBD", "TBA", "to be…Why
A pull request is for the person in the loop; this one reads like the run's log. The brief caps a bullet at one sentence, not a length, and code adds the rest a section at a time. braid#38 trimmed it once; it grew back.
Fix
Review each part for who reads it and why. Then:
Done when
That pull request, rewritten this way, reads in a minute and the owner prefers it. The next run's comes out the same way.
Where to look:
build_summary(src/osf/engine/prompts.py);_title,_pr_body(src/osf/forgejo.py); specpull-request-description.From the owner reading that pull request, 2026-11-20.
Shipped in #583 (merged as
c9c5e63, live on production), and archived in #584.summary-shapefails a summary out of that shape, naming what to change.make testandmake e2e, naming no lane, round or judge. Three replays of a simulated run's summary step passed the shape check too.