Run 203's findings: helpers past the backend's places, the code review's lint, a late compaction #576
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens (run 203, braid#565, findings 2 to 4; finding 1 shipped in pull request 566)
waitForTimeoutfailed the lanes' first round, costing 5.5 min.Fix
braidtool, as apply's brief does.Done when: each fix has a test that fails without it, and fix 4 is shown by a simulated run in which a helper's report wakes the step after its compaction.
Related, not in this change: braid#575 (the code review loops while its readers work).
Shipped in pull request 578, on production since
46464d0, and archived in pull request 579.braidtool'slintover the tests it changed, as apply's does. A test checks the line and the base commit it names. The brief stays within its budget (5,994 of 6,000 characters).compaction-woken-by-a-helper, has a helper's report wake the step after its compaction, as in run 203. Before the fix it counted the compaction as failed ("did not shrink the context (36000 -> 27000)") and went on in a fresh session. Now the compaction counts at 9,000 and the run succeeds../tools/test.shpassed on the laptop and on CI. The 7 smoke runs and the 6 compaction and helper runs pass.