In thorough, "Request changes" at the proposal review sends nothing back: the answer is recorded and apply goes ahead #176
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found while planning run 66, the combined verification run of 2026-10-16.
thorough's proposal gate,human.review-proposal, offers three answers:Nothing in
thoroughsends it back:script.record-review-decisiononly classes the answerrejectedin.osf/review/outcomes.json(osf.pipeline.review.classify_answer).script.dependencies→openspec.apply[…]build the proposal unchanged..osf/decisions.md, where apply may or may not act on them. In practice that is "Approve with edits" under another name, recorded as a rejection.solo(#151) does what the option says. After "Request changes",openspec.revise.solorevises the change in the proposing session and commits it, and the gate opens again as "Review the proposal (round 2)", up to round 3. The condition,proposal_changes_requested, reads the latest answered "Review the proposal…" gate indecisions.md, andthorough's gate has the same header.Wanted: in
thoroughand the pipelines derived from it, "Request changes" revises the change with the operator's words and asks again, assolodoes, up to round 3. The evidence of what each round asked is kept. If that is too much, the option should at least stop promising "send it back".Done when: a simulated run answers Request changes at the gate and sees a revise and a round-2 gate before apply, and the guide says what each answer does.
text, and decisions.md is written from the labels only #182Shipped in
bb5d87a(changeoperator-request-changes-revises, commit2e8a70a), live since 00:07Z on 2026-10-17, and archived in2f7d842.thoroughandgit-flow, Request changes at the proposal gate now runsagent.revise.operatorwith the operator's words (#182). It revises the change, validates it strictly, and writes.osf/review/operator-revision-<n>.md, saying what it changed for each point.script.record-review-decisionrecords every answered round.run_01M53R7621CJW6PCZG7S6R94HS, thorough on cmoriarty/braid-combined-test, vLLM). Request changes ("After a delete, the Links page should say 'Deleted.' at the top, once…") ran the revise. It wrote its note and added the requirement, two scenarios and the tasks. The revision was committed, and round 2's gate opened. Approve there skipped round 3 and went on to apply.outcomes.jsonrecordedrejected, thenapproved_unchanged.thorough-request-changes.git-flow's simulated run now also checks the loop is skipped on an approval.Closing.