An operator's words at a review gate never reach the agent: the Review lens sends them as text, and decisions.md is written from the labels only #182

Closed
opened 2026-10-16 19:02:13 -04:00 by cmoriarty · 1 comment
Owner

Found on run 67, the solo verification run (production 74e261c, 2026-10-16). At solo's proposal gate the operator answered Request changes and said what to change. The revise step's brief read "## What they said … (no words were given)", so it changed nothing and committed only .osf/decisions.md.

Why

  • The Review lens: ui/src/components/Review.tsx sends the decision as answers: [[label]] and the operator's words in text.
  • decisions.md: osf.engine.decisions writes the gate's section from the question and the answer labels only; text isn't written anywhere an agent reads.
  • The revise brief: build_propose_revise_solo takes the words from answer labels other than "Request changes", which the Review lens never sends.
  • The gate card: GateCard makes the operator choose either an option or their own words, since typing replaces the selection. Words alone are classed unknown, not a request for changes, so no revise runs.

So from the console, a person can't send a proposal back with what is wrong. The same loss hits thorough's "Approve with edits" ("say below what you want changed"): its words never reach apply.

The rest works. With the words sent as a second answer label, openspec.revise.solo.r2 got them verbatim and revised the proposal, spec, design and tasks as asked, in 7.1 min.

Wanted

  • A gate answer's text is written into its decisions.md section, as "The operator's words: …", and read by the revise brief and by apply.
  • The gate card lets a person pick an option and add words.
  • A test from the Review lens's answer shape ([[label]] plus text) to the revise brief containing the words.

Related: #176 (thorough's Request changes sends nothing back), #151.

Found on run 67, the solo verification run (production 74e261c, 2026-10-16). At `solo`'s proposal gate the operator answered **Request changes** and said what to change. The revise step's brief read "## What they said … (no words were given)", so it changed nothing and committed only `.osf/decisions.md`. **Why** - **The Review lens:** `ui/src/components/Review.tsx` sends the decision as `answers: [[label]]` and the operator's words in `text`. - **`decisions.md`:** `osf.engine.decisions` writes the gate's section from the question and the answer labels only; `text` isn't written anywhere an agent reads. - **The revise brief:** `build_propose_revise_solo` takes the words from answer labels other than "Request changes", which the Review lens never sends. - **The gate card:** `GateCard` makes the operator choose either an option or their own words, since typing replaces the selection. Words alone are classed `unknown`, not a request for changes, so no revise runs. So from the console, a person can't send a proposal back *with* what is wrong. The same loss hits `thorough`'s "Approve with edits" ("say below what you want changed"): its words never reach apply. **The rest works.** With the words sent as a second answer label, `openspec.revise.solo.r2` got them verbatim and revised the proposal, spec, design and tasks as asked, in 7.1 min. **Wanted** - A gate answer's `text` is written into its `decisions.md` section, as "The operator's words: …", and read by the revise brief and by apply. - The gate card lets a person pick an option and add words. - A test from the Review lens's answer shape (`[[label]]` plus `text`) to the revise brief containing the words. Related: #176 (thorough's Request changes sends nothing back), #151.
Author
Owner

Shipped in bb5d87a (change gate-words-reach-the-agent, commit d5ea170), live since 00:07Z on 2026-10-17, and archived in 2f7d842.

  • A gate keeps the words sent with its answer, in a new column, gate.answer_text (schema 14).
  • The gate's section of .osf/decisions.md ends with "The operator's words:" and the words quoted, so apply, the revise steps and every brief that reads the file have them.
  • The revise briefs quote them under "What they said".
  • A pipeline gate's card has a "Your words (optional)" field. It is sent with the chosen options, and typing leaves the choice in place.
  • Checked on production in the verification run (run_01M53R7621CJW6PCZG7S6R94HS, thorough on cmoriarty/braid-combined-test, vLLM). The proposal gate was answered Request changes, with words sent as the Review lens sends them. decisions.md quoted the words, and agent.revise.operator's brief had them under "What they said".
  • Tests: an API test from the Review lens's answer shape through the projection and the scheduler's materializer to decisions.md, the revise briefs, a browser spec for the card, and the simulated run thorough-request-changes.

Closing.

Shipped in bb5d87a (change `gate-words-reach-the-agent`, commit d5ea170), live since 00:07Z on 2026-10-17, and archived in 2f7d842. - A gate keeps the words sent with its answer, in a new column, `gate.answer_text` (schema 14). - The gate's section of `.osf/decisions.md` ends with "The operator's words:" and the words quoted, so apply, the revise steps and every brief that reads the file have them. - The revise briefs quote them under "What they said". - A pipeline gate's card has a "Your words (optional)" field. It is sent with the chosen options, and typing leaves the choice in place. - Checked on production in the verification run (`run_01M53R7621CJW6PCZG7S6R94HS`, thorough on cmoriarty/braid-combined-test, vLLM). The proposal gate was answered Request changes, with words sent as the Review lens sends them. `decisions.md` quoted the words, and agent.revise.operator's brief had them under "What they said". - Tests: an API test from the Review lens's answer shape through the projection and the scheduler's materializer to `decisions.md`, the revise briefs, a browser spec for the card, and the simulated run `thorough-request-changes`. Closing.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid#182
No description provided.