A visual fix loop goes in circles: the fixer never looks, and the judge keeps old page settings #266

Closed
opened 2026-10-27 18:47:23 -04:00 by cmoriarty · 2 comments
Owner

What happens
Run 123's judge failed rounds 3 to 7 on the same thing: no shadow or reflection on the ball. The fix loop then stopped for no progress.

  • The ball is about 10 px: the table fills 32% of a 1280×800 window. The fixer kept changing the shadow and reflection code and left the framing alone.
  • The fixer never looked: "I have not seen the result in a browser" (round 6).
  • Round 6's judge opened the game in low quality, where shadows are off by design. An earlier round had picked low, the game saved it, and the run's one browser kept it.

Fix

  • A fix round on a visual failure looks before it finishes: a screenshot of what the judge failed.
  • Each judge round starts with a fresh browser context, with no storage from earlier rounds.

Done when
A visual fix is checked in a screenshot before its round ends, and no judge round sees a setting an earlier round chose.

From the #260 re-run, run 123. See also #265.

**What happens** Run 123's judge failed rounds 3 to 7 on the same thing: no shadow or reflection on the ball. The fix loop then stopped for no progress. - The ball is about 10 px: the table fills 32% of a 1280×800 window. The fixer kept changing the shadow and reflection code and left the framing alone. - The fixer never looked: "I have not seen the result in a browser" (round 6). - Round 6's judge opened the game in low quality, where shadows are off by design. An earlier round had picked low, the game saved it, and the run's one browser kept it. **Fix** - A fix round on a visual failure looks before it finishes: a screenshot of what the judge failed. - Each judge round starts with a fresh browser context, with no storage from earlier rounds. **Done when** A visual fix is checked in a screenshot before its round ends, and no judge round sees a setting an earlier round chose. _From the #260 re-run, run 123. See also #265._
Author
Owner

Same cause, another symptom: twice a judge round's first browser call failed with "Target page, context or browser has been closed" (run 123 round 8, run 131 round 3). No agent called close: the page the run's one browser held from an earlier round was gone. A fresh browser context per judge round fixes this too.

**Same cause, another symptom:** twice a judge round's first browser call failed with "Target page, context or browser has been closed" (run 123 round 8, run 131 round 3). No agent called close: the page the run's one browser held from an earlier round was gone. A fresh browser context per judge round fixes this too.
Author
Owner

Verified on run 136, both halves.

  • The fixer looks: agent.fix opened the page with its own Playwright, at 1280 and 375 px, and checked both defects before writing its repair note.
  • The judge starts clean: round 2's brief had "A fresh look", and its first action was playwright_browser_close. Then it loaded the page again.
Verified on run 136, both halves. - **The fixer looks:** `agent.fix` opened the page with its own Playwright, at 1280 and 375 px, and checked both defects before writing its repair note. - **The judge starts clean:** round 2's brief had "A fresh look", and its first action was `playwright_browser_close`. Then it loaded the page again.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid#266
No description provided.