Spine: separate a step's status from what a checking step found #265

Closed
opened 2026-10-27 18:42:07 -04:00 by cmoriarty · 1 comment
Owner

What happens

A step's ✓ / ✗ answers three different questions at once:

  • Progress: is the step finished?
  • Status: did the step do its job: run, error, skip, retry?
  • Outcome: what did a checking step find?

So a judge that ran fine and found failures shows a green ✓: run 123's rounds 2 to 7 each failed 2 to 4 criteria, and run 134's judge failed, and every one was a green ✓. A red test round shows ✗ (#179), as if the step broke. The Verify & fix band counts finished steps ("21 of 21", a full bar) while the loop is still red.

Fix

One signal per question:

  • Status is the glyph's shape: ✓ done, ▶ running, ⊘ skipped, ↻n retried, ✗ only when the step itself broke.
  • Outcome is a verdict chip on every checking step (tests, judge, review lenses, code review, CI): a coloured dot with a word and a count, e.g. ● fail · 1 of 9, ● red · lint, ● 2 blocking. Never colour alone.
  • Progress is the band: the loop's round and its state ("round 2 · fail → fixing"), not a count of finished steps.
✓ agent.judge     ● fail · 1 of 9     14m 15s
▶ agent.fix       silent for 1m 25s

Done when

A glance at the spine tells a broken step (✗) from a check that found problems (✓ with a red chip), and the band shows whether the loop is still red.

Run 123's spine (before)

Run 123's spine

From the #260 re-run (run 123) and #279 (run 134).

**What happens** A step's ✓ / ✗ answers three different questions at once: - **Progress:** is the step finished? - **Status:** did the step do its job: run, error, skip, retry? - **Outcome:** what did a checking step find? So a judge that ran fine and found failures shows a green ✓: run 123's rounds 2 to 7 each failed 2 to 4 criteria, and run 134's judge failed, and every one was a green ✓. A red test round shows ✗ (#179), as if the step broke. The Verify & fix band counts finished steps ("21 of 21", a full bar) while the loop is still red. **Fix** One signal per question: - **Status is the glyph's shape:** ✓ done, ▶ running, ⊘ skipped, ↻n retried, ✗ only when the step itself broke. - **Outcome is a verdict chip** on every checking step (tests, judge, review lenses, code review, CI): a coloured dot with a word and a count, e.g. `● fail · 1 of 9`, `● red · lint`, `● 2 blocking`. Never colour alone. - **Progress is the band:** the loop's round and its state ("round 2 · fail → fixing"), not a count of finished steps. ``` ✓ agent.judge ● fail · 1 of 9 14m 15s ▶ agent.fix silent for 1m 25s ``` **Done when** A glance at the spine tells a broken step (✗) from a check that found problems (✓ with a red chip), and the band shows whether the loop is still red. **Run 123's spine (before)** ![Run 123's spine](https://forgejo.underthere.xyz/attachments/887d862d-f307-4e38-9c9c-9a9dd1c157d2) _From the #260 re-run (run 123) and #279 (run 134)._
cmoriarty changed title from The spine shows a failed judge round as a green check to Spine: separate a step's status from what a checking step found 2026-10-28 16:31:44 -04:00
Author
Owner

Shipped in PR #284 (merge 8c527d6), live on production.

Verified on run 136's spine: checking steps keep ✓ and show a verdict chip under the row, the combined reviewer's reading 7 should-fix · 5 note. The chip's colours and words for reviews are now #287, and a findings panel is #288. The loop band and chips are covered by ui/e2e/run.spec.ts and ui/src/lib/loopState.test.ts.

Shipped in PR #284 (merge 8c527d6), live on production. Verified on run 136's spine: checking steps keep ✓ and show a verdict chip under the row, the combined reviewer's reading `7 should-fix · 5 note`. The chip's colours and words for reviews are now #287, and a findings panel is #288. The loop band and chips are covered by `ui/e2e/run.spec.ts` and `ui/src/lib/loopState.test.ts`.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid#265
No description provided.