Spine: separate a step's status from what a checking step found #265
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
A step's ✓ / ✗ answers three different questions at once:
So a judge that ran fine and found failures shows a green ✓: run 123's rounds 2 to 7 each failed 2 to 4 criteria, and run 134's judge failed, and every one was a green ✓. A red test round shows ✗ (#179), as if the step broke. The Verify & fix band counts finished steps ("21 of 21", a full bar) while the loop is still red.
Fix
One signal per question:
● fail · 1 of 9,● red · lint,● 2 blocking. Never colour alone.Done when
A glance at the spine tells a broken step (✗) from a check that found problems (✓ with a red chip), and the band shows whether the loop is still red.
Run 123's spine (before)
From the #260 re-run (run 123) and #279 (run 134).
The spine shows a failed judge round as a green checkto Spine: separate a step's status from what a checking step foundShipped in PR #284 (merge
8c527d6), live on production.Verified on run 136's spine: checking steps keep ✓ and show a verdict chip under the row, the combined reviewer's reading
7 should-fix · 5 note. The chip's colours and words for reviews are now #287, and a findings panel is #288. The loop band and chips are covered byui/e2e/run.spec.tsandui/src/lib/loopState.test.ts.