A file the tests create, like a SQLite database, fails a tests-only step as a change it made #326
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
Run 157's
agent.write-spec-tests[financial-models]wrote one test file, and its tests passed. Running them createdtest_stock.dbat the repository root, and the step failed its tests-only check: "it changed test_stock.db; a test's helper goes under a test directory". On Free the siblings run one after another, so the other three capabilities' steps were skipped and the run failed.Fix
A file that appeared only from running the project's tests is not the step's change: anything untracked that the lanes' own runs leave behind, or a database or cache file (
*.db,*.sqlite,.pytest_cache) not written by an edit or write tool call. Leave it out of the check, and add a Node or Python.gitignoreentry for it when Braid writes one (#273).Done when
A spec-test step whose tests create
test.dbpasses the tests-only check, and one that edits application code still fails it. A test covers both.Confirmed on production (
de4c67e, PR #328); closing. Run 157, resumed:agent.write-spec-tests[financial-models], the step that failed ontest_stock.db, passed its tests-only check on attempt 2. The other three capabilities' steps passed too.