A file the tests create, like a SQLite database, fails a tests-only step as a change it made #326

Closed
opened 2026-10-30 02:21:40 -04:00 by cmoriarty · 1 comment
Owner

What happens
Run 157's agent.write-spec-tests[financial-models] wrote one test file, and its tests passed. Running them created test_stock.db at the repository root, and the step failed its tests-only check: "it changed test_stock.db; a test's helper goes under a test directory". On Free the siblings run one after another, so the other three capabilities' steps were skipped and the run failed.

Fix
A file that appeared only from running the project's tests is not the step's change: anything untracked that the lanes' own runs leave behind, or a database or cache file (*.db, *.sqlite, .pytest_cache) not written by an edit or write tool call. Leave it out of the check, and add a Node or Python .gitignore entry for it when Braid writes one (#273).

Done when
A spec-test step whose tests create test.db passes the tests-only check, and one that edits application code still fails it. A test covers both.

**What happens** Run 157's `agent.write-spec-tests[financial-models]` wrote one test file, and its tests passed. Running them created `test_stock.db` at the repository root, and the step failed its tests-only check: "it changed test_stock.db; a test's helper goes under a test directory". On Free the siblings run one after another, so the other three capabilities' steps were skipped and the run failed. **Fix** A file that appeared only from running the project's tests is not the step's change: anything untracked that the lanes' own runs leave behind, or a database or cache file (`*.db`, `*.sqlite`, `.pytest_cache`) not written by an edit or write tool call. Leave it out of the check, and add a Node or Python `.gitignore` entry for it when Braid writes one (#273). **Done when** A spec-test step whose tests create `test.db` passes the tests-only check, and one that edits application code still fails it. A test covers both.
Author
Owner

Confirmed on production (de4c67e, PR #328); closing. Run 157, resumed: agent.write-spec-tests[financial-models], the step that failed on test_stock.db, passed its tests-only check on attempt 2. The other three capabilities' steps passed too.

**Confirmed on production (de4c67e, PR #328); closing.** Run 157, resumed: `agent.write-spec-tests[financial-models]`, the step that failed on `test_stock.db`, passed its tests-only check on attempt 2. The other three capabilities' steps passed too.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid#326
No description provided.