A Free run can't be resumed: its router key was deactivated when it ended #331
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
Run 157 (Free) failed, and was resumed after #326's fix deployed. Its spec-test steps passed. Then
agent.code-reviewburned all 5 attempts in 3 seconds: each request to the Free router got 401provider.auth. When a run ends,FreeService.releasedeactivates its router key and deletes its virtual models. On a restart,attachputs the chains back, which recreates the virtual models, but never makes the key again. So a failed or stopped Free run cannot be resumed.Fix
On
attach, check the run's key. When the router lists it inactive or not at all, make a new key, asprovisiondoes, and write it to the same file the run's config reads.Done when
A Free run resumed after it ended reaches the router. A test with the fake router covers a released key made again.
Confirmed on production (
add5fd1, PR #330); closing. Run 157, resumed again after the deploy:agent.code-reviewsucceeded on attempt 6, the first after the fix. Attempts 1 to 5 had each died at once on 401provider.authwith the key released when the run ended. The run went on to its Visual check.