A game is listed twice when thetvapp spells a school otherwise (BYU, UL Monroe, IUPUI) #196
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
The owner, 2026-11-18, with a screenshot of the Games page: "Looks like there's a duplicate. This has happened 2 other times now."
The live game list at about 01:15Z on 2026-11-19 showed three games twice. Each time, a thetvapp row was listed as its own entry beside the ESPN game it names:
thetvapp-9287915560LSU Tigers vs. Louisiana-Monroe Warhawksmens-college-basketball-401917982LSU vs. UL Monroethetvapp-9287972120Brigham Young Cougars vs. Northern Colorado Bearsmens-college-basketball-401921742BYU vs. N Coloradothetvapp-9287745880Penn St Nittany Lions vs. IUPUI Jaguarsmens-college-basketball-401917181Penn State vs. IU IndyThe thetvapp entry has no logos (the tile shows initials, "LT" and "LMW"), and its stream is not among the ESPN game's links.
Why
_merge_tvapp_list(backend/app/games.py) joins a row to an entry only when both team names match (hub.matchup_matches,hub.team_match).Thetvapp writes schools out in full, or by an older name, where ESPN abbreviates or renames. Each time one of these showed up so far, the matcher was taught one more spelling:
_SCHOOL_NAMES, PR #89);There will be more: USC, UCF, UNLV, UTEP, SMU, TCU, VCU, UMass, Pitt…
The idea
A row that no entry matches by both names joins the one entry of its sport that meets all of these:
With two such entries (a doubleheader, a tournament day), the row stays its own entry, as today.
Done when
Specs:
live-game-list.Merged in PR #197 (merge
0b05249) and fixed in PR #198 (merge893c50f), live as893c50fsince 2026-11-19 16:21Z.The first deploy did not work. PR #197 went live at 02:29Z, and LSU vs. UL Monroe and BYU vs. N Colorado stayed listed twice. The rule takes a live row's time as now, and it read now from
games._now(). That istime.monotonic(), the clock of the list's cache, so comparing it with the entry's unix start never matched any live row. The tests had stubbed_nowwith a unix time, which hid it.The fix. PR #198 reads
games._wall(). The tests now stub the wall clock only; with the old clock put back, the live-row tests fail. Replayed on the list read right after the first deploy, both rows join their games.What the live list shows now.
Not seen live yet: LSU's and BYU's games had ended by the deploy, so no live row has been seen joining by its mascot. The next game a list spells otherwise is the test.