A live thetvapp row is timed by the wall clock, not the list cache's (#196) #198

Merged
cmoriarty merged 1 commit from thetvapp-mascot-wall-clock into main 2026-11-19 11:19:58 -05:00
Owner

Follow-up to #197, which merged and deployed (live as 0b05249) but left LSU vs. UL Monroe and BYU vs. N Colorado listed twice.

Why. A live thetvapp row gives no start, so the rule takes its time as now. _tvapp_mascot_match read now from games._now(), which is time.monotonic(): the clock of the list's cache, which counts from the machine's start. It then compared that with the entry's unix start, so no live row ever joined. The tests had stubbed _now with a unix time, which hid it.

The fix. It reads games._wall(). The tests now stub _wall and leave _now running; with the old clock put back, the two live-row tests fail.

Checks

  • Replayed on the live list read right after the #197 deploy: LSU and BYU both join their ESPN games, and Florida State vs. Purdue (no ESPN entry yet) stays its own.
  • make test: 1528 passed, 1 skipped.
  • make e2e: every leg passed.

Live, after the deploy: each game is listed once, and the ESPN game carries the thetvapp link.

Refs #196

🤖 Generated with Claude Code

Follow-up to #197, which merged and deployed (live as `0b05249`) but left LSU vs. UL Monroe and BYU vs. N Colorado listed twice. **Why.** A live thetvapp row gives no start, so the rule takes its time as now. `_tvapp_mascot_match` read now from `games._now()`, which is `time.monotonic()`: the clock of the list's cache, which counts from the machine's start. It then compared that with the entry's unix start, so no live row ever joined. The tests had stubbed `_now` with a unix time, which hid it. **The fix.** It reads `games._wall()`. The tests now stub `_wall` and leave `_now` running; with the old clock put back, the two live-row tests fail. **Checks** - Replayed on the live list read right after the #197 deploy: LSU and BYU both join their ESPN games, and Florida State vs. Purdue (no ESPN entry yet) stays its own. - `make test`: 1528 passed, 1 skipped. - `make e2e`: every leg passed. **Live, after the deploy:** each game is listed once, and the ESPN game carries the thetvapp link. Refs #196 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The first deploy of #196 (PR #197, live as 0b05249) left LSU vs. UL
Monroe and BYU vs. N Colorado listed twice. A live row gives no start,
so its time is now, and _tvapp_mascot_match read now from games._now(),
which is time.monotonic() (the clock of the list's cache), and compared
it with the entry's unix start. No live row ever joined. The tests had
stubbed _now with a unix time, which hid it.

It reads games._wall() now. The tests stub _wall and leave _now running;
with the old clock put back, the two live-row tests fail. Replayed on the
list read right after that deploy, both rows join their games, and
Florida State vs. Purdue (no ESPN entry yet) stays its own.

make test 1528 passed; make e2e passed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cmoriarty deleted branch thetvapp-mascot-wall-clock 2026-11-19 11:19:58 -05:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/sports-breaker!198
No description provided.