A step stopped by the operator is recorded and drawn as failed: say "interrupted", in a calm tone #152
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stop Run works, but afterwards the console tells a story of failure. The step that was running shows a red ✗ and "failed", its band says "1 failed", Step details lists the attempt as "#1 failed", and the transcript ends with a red "✗ interrupted" and "Implement task group 2 — failed".
Cause
An attempt that ends because of the operator's interrupt finishes with reason
aborted(AgentExecutor,TerminalReason.ABORTED) and is recorded asosf.step.failed.StepStatus.INTERRUPTEDexists, and the console has a look for it, but nothing ever sets it, and that look uses the error tone (text-bad).Want
When the operator ends a step with Stop, whether on the run or on the step, the step is interrupted, not failed, everywhere it is shown:
interrupted. A timeout, budget abort or crash staysfailed. Mediation (#119) does not retry an interrupted step. Resume accepts one. The run staysabandoned(shown as "stopped").A simulated run (
osf.sim) that stops a run mid-apply should cover the engine side, and a browser spec the console side.Shipped as
stopped-step-reads-interrupted.osf.step.interrupted(who stopped it, and why), notosf.step.failed. The attempt closesinterrupted. Mediation never retries it, and Resume carries it on in place. A time-out, a budget abort or a crash stays failed. A run whose only endings are interruptions finishes stopped and sends no notification.Verified. The fast and full lanes passed on the integrated batch (3,388 backend tests, 681 vitest, 249 browser specs with the slow and live ones, 29 of 29 simulated runs), and it is live on production as
57971c2(deploy run 138, self-checkbraid-selfcheck: ok). Archived ina6ae0dc. Two new simulated runs,stop-run-mid-applyandstop-step-mid-apply. The first found a race when the batch was put together: a tick between the resume and the steps being put back marked a fan-out unreachable for good. That is fixed and tested (06291ee).On production, a throwaway thorough run on cmoriarty/scratch (run 63) was stopped at
openspec.explore. The step, its attempt and Step details read interrupted in the muted tone, the run read stopped with failed 0, and there was noosf.step.failed. Resume started attempt 2 in place, and a run Stop interrupted it again. The run was then deleted.One small follow-up I noticed: on an interrupted step, the message box says "No agent is running for this step. Redo runs it again.", while the way to carry on is Resume run.
step.skipped: <label>and never says the step was put back #175