On a step the operator stopped, the message box still says "Redo runs it again" while Resume run carries it on #173
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Follow-up to #152, noticed on production while checking it (its last comment).
Since #152 a step the operator stops reads
interrupted, and Resume run on the run header carries it on in place, with its work kept. Select that step and the composer's disabled message box still reads:Redo starts the step over and throws its work away. For an interrupted step of a run that can be resumed, Resume run is the way on.
Wanted: on an interrupted agent step of a run whose header offers Resume run, the placeholder says it was stopped, that Resume run carries it on where it stopped, and that Redo starts it over, e.g. "Stopped. Resume run carries it on where it stopped; Redo starts it over." Every other step with no running agent (failed, succeeded, skipped, …) keeps today's wording.
Done when: a vitest holds the wording choice,
ui/e2e/step-interrupted.spec.tschecks it on the fixture runrun_stopped, and it ships.Shipped as
resume-hint-on-a-stopped-step(adde897, archived in57f9a21). It goes live with the next deploy. The push carried[skip ci]so that production was not restarted under two runs being measured (run 64, the #139 baseline, and run 65, #170's comparison run).canResumeas the header's button: a stopped run, or a failed one, still on the ledger. All other cases keep "No agent is running for this step. Redo runs it again.": a failed, cancelled or finished step, or an interrupted step of a run that is still running, archived or reclaimed.composer: the requirement "The composer is disabled when no agent would hear it" gains three scenarios: a stopped step, the cancelled step of the same run, and a run that cannot be resumed.Verified. The wording is chosen in
ui/src/lib/composerHint.tsand held by a vitest.ui/e2e/step-interrupted.spec.tschecks it on the fixture's stopped run, checks that its cancelled step keeps the Redo wording, and checks that the text is not cut off at 1440, 768 and 390 px. The new browser test fails on a build with the old wording. Its cut-off check fails on a placeholder three times as long. The fast lane passed: 3,381 backend tests, 685 vitest and 235 browser specs. Not yet checked on production, since it isn't deployed.Live on production since 14:31:43Z, as
57f9a21(manual deploy run 139, after runs 64 and 65 were stopped).Checked in a real browser on production, on run 65's
openspec.apply[1], which the operator's Stop run left interrupted. At 1440 and 390 px the message box is disabled and reads "Stopped. Resume run carries it on where it stopped; Redo starts it over.", with Resume run in the run's header. The served bundle carries the new text. The database counts are unchanged across the restart.step.skipped: <label>and never says the step was put back #175