After Stop then Resume, a step's transcript reads a bare step.skipped: <label> and never says the step was put back #175
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found in run 66 (the combined verification run), after Stop run and then Resume run. One of the steps the Stop had made unreachable was
script.run-tests.Its transcript reads
step.skipped: script.run-tests, and then the step runs. Two things are wrong with that:skip_kindandblocked_byrecord;Cause
ui/src/lib/format.ts:GRAPH_MARKShas no entry forosf.step.skipped.graphTexttherefore falls back to the event's type with.osfstripped, plus the label, givingstep.skipped: <label>. The skip'sskip_kind,reasonandblocked_byare never read.osf.step.readyis inQUIET_OSF, which is right for an ordinary promotion. But Resume's put-back is the same event with the reducer's override (status: pending,reason: resumed,scheduler._reopen_steps), and so is a redo's put-back (reason: upstream_redo,_unskip_dependents). Both are dropped.A smaller relative of the same thing:
osf.run.abandoned("run stopped") is inERROR_GRAPH_TYPES, so an operator's Stop is drawn as an error in the run's transcript. #152 made the step's side of a Stop calm and left this one as it was.Want
skipped: blocked by <blocked_by>, or, behind an operator's Stop,skipped: the run was stopped at <blocked_by>.skipped: <reason>.step.skipped:.put back by Resume runforreason: resumed, andput back by the redo of <unskipped_by>forreason: upstream_redo. Ordinary promotions stay quiet.osf.run.abandonedwith actoroperator) reads■ run stoppedin the calm tone #152 uses, not as an error.Done when
ui/src/lib/format.test.tsfor each wording.ui/e2e/step-interrupted.spec.ts, fixturerun_stopped) shows a step skipped by the Stop and put back by a Resume with both rows, and nostep.skipped:.stop-run-mid-apply's transcript, read through the formatter, has nostep.skipped:row.Related: #152, #173, #174.
step.skipp…#179Shipped in
74e261c(changestop-and-resume-read-calmly, commit684779a), live since 21:30Z on 2026-10-16.<step> skipped. Under it:blocked by <step>, which did not finishfor an unreachable skip, or the skip's reason for one that was not needed.<step> put back by Resume run, or… by the redo of <step>. An ordinary promotion stays quiet.■ run stopped, in the calm tone.agent.reconcile-tasksread "agent.reconcile-tasks skipped / blocked by openspec.apply.solo, which did not finish". Resume run added "agent.reconcile-tasks put back by Resume run".Two follow-ups from run 67 are in #179, which is in the next deploy:
The Python formatter (
osfd transcript, notifications) gets the same wording there too. The change is archived in the next push. Closing.