After Stop then Resume, a step's transcript reads a bare step.skipped: <label> and never says the step was put back #175

Closed
opened 2026-10-16 16:45:52 -04:00 by cmoriarty · 1 comment
Owner

Found in run 66 (the combined verification run), after Stop run and then Resume run. One of the steps the Stop had made unreachable was script.run-tests.

Its transcript reads step.skipped: script.run-tests, and then the step runs. Two things are wrong with that:

  • the row doesn't say why the step was skipped: unreachable behind the stopped step, as skip_kind and blocked_by record;
  • nothing says the Resume put it back, so the transcript reads skipped, then ran.

Cause

ui/src/lib/format.ts:

  • GRAPH_MARKS has no entry for osf.step.skipped. graphText therefore falls back to the event's type with .osf stripped, plus the label, giving step.skipped: <label>. The skip's skip_kind, reason and blocked_by are never read.
  • osf.step.ready is in QUIET_OSF, which is right for an ordinary promotion. But Resume's put-back is the same event with the reducer's override (status: pending, reason: resumed, scheduler._reopen_steps), and so is a redo's put-back (reason: upstream_redo, _unskip_dependents). Both are dropped.

A smaller relative of the same thing: osf.run.abandoned ("run stopped") is in ERROR_GRAPH_TYPES, so an operator's Stop is drawn as an error in the run's transcript. #152 made the step's side of a Stop calm and left this one as it was.

Want

  • A skip reads as a skip, with its reason.
    • Unreachable: skipped: blocked by <blocked_by>, or, behind an operator's Stop, skipped: the run was stopped at <blocked_by>.
    • Not needed: skipped: <reason>.
    • Never step.skipped:.
  • A put-back is drawn: put back by Resume run for reason: resumed, and put back by the redo of <unskipped_by> for reason: upstream_redo. Ordinary promotions stay quiet.
  • An operator's Stop of the run (osf.run.abandoned with actor operator) reads ■ run stopped in the calm tone #152 uses, not as an error.

Done when

  • Unit tests in ui/src/lib/format.test.ts for each wording.
  • The browser spec for a stopped run (ui/e2e/step-interrupted.spec.ts, fixture run_stopped) shows a step skipped by the Stop and put back by a Resume with both rows, and no step.skipped:.
  • The simulated run stop-run-mid-apply's transcript, read through the formatter, has no step.skipped: row.

Related: #152, #173, #174.

Found in run 66 (the combined verification run), after **Stop run** and then **Resume run**. One of the steps the Stop had made unreachable was `script.run-tests`. Its transcript reads `step.skipped: script.run-tests`, and then the step runs. Two things are wrong with that: - the row doesn't say why the step was skipped: unreachable behind the stopped step, as `skip_kind` and `blocked_by` record; - nothing says the Resume put it back, so the transcript reads skipped, then ran. ## Cause `ui/src/lib/format.ts`: - `GRAPH_MARKS` has no entry for `osf.step.skipped`. `graphText` therefore falls back to the event's type with `.osf` stripped, plus the label, giving `step.skipped: <label>`. The skip's `skip_kind`, `reason` and `blocked_by` are never read. - `osf.step.ready` is in `QUIET_OSF`, which is right for an ordinary promotion. But Resume's put-back is the same event with the reducer's override (`status: pending`, `reason: resumed`, `scheduler._reopen_steps`), and so is a redo's put-back (`reason: upstream_redo`, `_unskip_dependents`). Both are dropped. A smaller relative of the same thing: `osf.run.abandoned` ("run stopped") is in `ERROR_GRAPH_TYPES`, so an operator's Stop is drawn as an error in the run's transcript. #152 made the step's side of a Stop calm and left this one as it was. ## Want - **A skip reads as a skip, with its reason.** - Unreachable: `skipped: blocked by <blocked_by>`, or, behind an operator's Stop, `skipped: the run was stopped at <blocked_by>`. - Not needed: `skipped: <reason>`. - Never `step.skipped:`. - **A put-back is drawn:** `put back by Resume run` for `reason: resumed`, and `put back by the redo of <unskipped_by>` for `reason: upstream_redo`. Ordinary promotions stay quiet. - **An operator's Stop of the run** (`osf.run.abandoned` with actor `operator`) reads `■ run stopped` in the calm tone #152 uses, not as an error. ## Done when - Unit tests in `ui/src/lib/format.test.ts` for each wording. - The browser spec for a stopped run (`ui/e2e/step-interrupted.spec.ts`, fixture `run_stopped`) shows a step skipped by the Stop and put back by a Resume with both rows, and no `step.skipped:`. - The simulated run `stop-run-mid-apply`'s transcript, read through the formatter, has no `step.skipped:` row. Related: #152, #173, #174.
Author
Owner

Shipped in 74e261c (change stop-and-resume-read-calmly, commit 684779a), live since 21:30Z on 2026-10-16.

  • A skip reads <step> skipped. Under it: blocked by <step>, which did not finish for an unreachable skip, or the skip's reason for one that was not needed.
  • A put-back reads <step> put back by Resume run, or … by the redo of <step>. An ordinary promotion stays quiet.
  • An operator's Stop of the run reads ■ run stopped, in the calm tone.
  • Checked on production in run 67. Before Resume, agent.reconcile-tasks read "agent.reconcile-tasks skipped / blocked by openspec.apply.solo, which did not finish". Resume run added "agent.reconcile-tasks put back by Resume run".

Two follow-ups from run 67 are in #179, which is in the next deploy:

  • the transcript folded a skip, its put-back and a later skip into "2 × skipped";
  • a long skip reason beside the row cut the row's words short.

The Python formatter (osfd transcript, notifications) gets the same wording there too. The change is archived in the next push. Closing.

Shipped in 74e261c (change `stop-and-resume-read-calmly`, commit 684779a), live since 21:30Z on 2026-10-16. - A skip reads `<step> skipped`. Under it: `blocked by <step>, which did not finish` for an unreachable skip, or the skip's reason for one that was not needed. - A put-back reads `<step> put back by Resume run`, or `… by the redo of <step>`. An ordinary promotion stays quiet. - An operator's Stop of the run reads `■ run stopped`, in the calm tone. - Checked on production in run 67. Before Resume, `agent.reconcile-tasks` read "agent.reconcile-tasks skipped / blocked by openspec.apply.solo, which did not finish". Resume run added "agent.reconcile-tasks put back by Resume run". Two follow-ups from run 67 are in #179, which is in the next deploy: - the transcript folded a skip, its put-back and a later skip into "2 × skipped"; - a long skip reason beside the row cut the row's words short. The Python formatter (`osfd transcript`, notifications) gets the same wording there too. The change is archived in the next push. Closing.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid#175
No description provided.