Review chips: green beside seven things to fix, and "note" means nothing to a reader #287

Closed
opened 2026-10-28 19:15:47 -04:00 by cmoriarty · 1 comment
Owner

What happens

Run 136's agent.review.combined row shows a green dot and, in green, 7 should-fix · 5 note. The chip (#265) treats a review as pass or fail, and green means only "nothing blocking". So seven things to fix read as good, and "note" is Braid's internal severity, which tells a reader nothing. The code review's chip has the same problem (2 major · 1 minor).

Fix

A review's chip says what it found, in the tone of its worst finding:

  • red: 2 blocking
  • amber: 7 to fix (should-fix and major), with → revised once the revision ran
  • grey: 5 notes when that is all
  • green: nothing found

Plural words, and a hover that names each kind ("to fix: worth changing before the build; notes: for the record").

Done when

A review with should-fix findings never shows green, and each word on the chip reads without knowing Braid's severities.

From #279, run 136. Follows #265.

**What happens** Run 136's `agent.review.combined` row shows a green dot and, in green, `7 should-fix · 5 note`. The chip (#265) treats a review as pass or fail, and green means only "nothing blocking". So seven things to fix read as good, and "note" is Braid's internal severity, which tells a reader nothing. The code review's chip has the same problem (`2 major · 1 minor`). **Fix** A review's chip says what it found, in the tone of its worst finding: - red: `2 blocking` - amber: `7 to fix` (should-fix and major), with `→ revised` once the revision ran - grey: `5 notes` when that is all - green: `nothing found` Plural words, and a hover that names each kind ("to fix: worth changing before the build; notes: for the record"). **Done when** A review with should-fix findings never shows green, and each word on the chip reads without knowing Braid's severities. _From #279, run 136. Follows #265._
Author
Owner

Shipped in PR #297 (1d98b25). A review's chip counts its findings as the digest merges them (6 to fix · 5 notes), in the colour of the worst: red blocking, amber to fix, grey notes, green nothing found. The code review counts major as to fix and minor as notes.

Verified on run 137: the combined reviewer's chip reads 6 to fix · 6 notes in amber (warned), counted from the merged findings.

Shipped in PR #297 (1d98b25). A review's chip counts its findings as the digest merges them (`6 to fix · 5 notes`), in the colour of the worst: red blocking, amber to fix, grey notes, green `nothing found`. The code review counts major as to fix and minor as notes. Verified on run 137: the combined reviewer's chip reads `6 to fix · 6 notes` in amber (`warned`), counted from the merged findings.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid#287
No description provided.