Review chips: green beside seven things to fix, and "note" means nothing to a reader #287
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
Run 136's
agent.review.combinedrow shows a green dot and, in green,7 should-fix · 5 note. The chip (#265) treats a review as pass or fail, and green means only "nothing blocking". So seven things to fix read as good, and "note" is Braid's internal severity, which tells a reader nothing. The code review's chip has the same problem (2 major · 1 minor).Fix
A review's chip says what it found, in the tone of its worst finding:
2 blocking7 to fix(should-fix and major), with→ revisedonce the revision ran5 noteswhen that is allnothing foundPlural words, and a hover that names each kind ("to fix: worth changing before the build; notes: for the record").
Done when
A review with should-fix findings never shows green, and each word on the chip reads without knowing Braid's severities.
From #279, run 136. Follows #265.
Shipped in PR #297 (
1d98b25). A review's chip counts its findings as the digest merges them (6 to fix · 5 notes), in the colour of the worst: red blocking, amber to fix, grey notes, greennothing found. The code review counts major as to fix and minor as notes.Verified on run 137: the combined reviewer's chip reads
6 to fix · 6 notesin amber (warned), counted from the merged findings.