Show a review's findings as a panel, not only in the agent's own words #288
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
A review's findings can only be read in the agent's transcript, in whatever words it chose. Run 136's combined reviewer left a good summary; another run may not. The chip (#287) gives counts, not the findings.
Fix
A findings panel built from the review's record (the digest, so duplicates are merged and each finding names the lenses that raised it), not from the agent's prose:
0 blocking · 6 to fix · 5 notes, with a bar split by the same colours.spec.md), the lenses (spec,test), the quoted line in mono, and what became of it (revised, orkept, because…).Needed:
titleper finding (≤ 60 characters); todayproblemis a paragraph.revision-1.md.Done when
From the spine, a person sees each finding of a review in one place, what it is about, and whether it was acted on, without opening a transcript.
From #279, run 136. With #287.
Shipped in PR #297 (
1d98b25). Lenses give each finding a title; the revision writes.osf/review/r<n>/outcomes.json.GET /api/runs/{id}/review/{round}serves a round, and a panel under the review and revision steps lists it by weight: title, document, lenses, revised or kept, and opens to the quote, problem and suggestion. A click on a review chip opens it.Verified on run 137: a click on the chip selected the step and opened the panel,
0 blocking · 6 to fix · 6 notes, every finding with the reviewer's own title ("Currency output varies with browser locale"). The revision wroteoutcomes.json, all six to-fix findingsrevisedwith a sentence each, andGET /api/runs/{id}/review/1serves them.