Proposal gate: a summary and six checks in place of the diff #537
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
diff, which is not a file in the worktree, so it shows an error.What we want
Done when
On a seeded run in a 390 px window: the gate opens on the summary, a note on one call reaches the revise step's brief, and nothing scrolls sideways.
Where to look:
ui/src/components/Review.tsx,ui/src/components/GateCard.tsx,src/osf/engine/executors.py(HumanExecutor),src/osf/pipeline/review.py.Slice 1 of braid#26, which holds the audit, the design and a mock.
Shipped in pull request #539 and archived in #540.
What shipped
Evidence, from the laptop
ui/e2e/proposal-summary.spec.tsreads a proposal gate at 390 px and sends a note back. It failed at the missing Review button before an answered gate could be opened again.test_a_plan_review_carries_no_summary_though_its_worktree_holds_one_changefailed first: a plan review would have been given a summary.thoroughrun's gate in a browser, with a note and Approve with edits../tools/test.shpassed in 52 s, and the smoke runs 7 of 7.On production since 2026-11-14 (commit
1d512bf, database at schema 19). An old gate, which holds no summary, opens as it did before. The first summary will come with the nextthoroughorgit-flowrun.Known, and not changed