Proposal gate: a summary and six checks in place of the diff #537

Closed
opened 2026-11-13 15:40:49 -05:00 by cmoriarty · 1 comment
Owner

What happens

  • The proposal gate shows the change as a diff. Run 195's was 11,720 words, about 50 minutes to read.
  • The 15 calls its explore step wrote for the reviewer are not on the gate.
  • The card's "What you are approving" opens diff, which is not a file in the worktree, so it shows an error.

What we want

  • When the gate opens, Braid assembles what it shows from the change's own documents: what it understood, what it will build, the calls it made, what is left out, the risks. No model writes it and no step is added.
  • Six checks and one verdict: Valid, Complete, Existing behaviour, Reviewed, Size, Clear of other work.
  • A note on a call goes to the reviser with Request changes.
  • The full text stays one tap away. The page reads at 390 px and on a desktop.

Done when

On a seeded run in a 390 px window: the gate opens on the summary, a note on one call reaches the revise step's brief, and nothing scrolls sideways.

Where to look: ui/src/components/Review.tsx, ui/src/components/GateCard.tsx, src/osf/engine/executors.py (HumanExecutor), src/osf/pipeline/review.py.

Slice 1 of braid#26, which holds the audit, the design and a mock.

**What happens** - The proposal gate shows the change as a diff. Run 195's was 11,720 words, about 50 minutes to read. - The 15 calls its explore step wrote for the reviewer are not on the gate. - The card's "What you are approving" opens `diff`, which is not a file in the worktree, so it shows an error. **What we want** - When the gate opens, Braid assembles what it shows from the change's own documents: what it understood, what it will build, the calls it made, what is left out, the risks. No model writes it and no step is added. - Six checks and one verdict: Valid, Complete, Existing behaviour, Reviewed, Size, Clear of other work. - A note on a call goes to the reviser with Request changes. - The full text stays one tap away. The page reads at 390 px and on a desktop. **Done when** On a seeded run in a 390 px window: the gate opens on the summary, a note on one call reaches the revise step's brief, and nothing scrolls sideways. Where to look: `ui/src/components/Review.tsx`, `ui/src/components/GateCard.tsx`, `src/osf/engine/executors.py` (`HumanExecutor`), `src/osf/pipeline/review.py`. *Slice 1 of braid#26, which holds the audit, the design and a mock.*
Author
Owner

Shipped in pull request #539 and archived in #540.

What shipped

  • The proposal gate opens on a summary assembled from the change's own documents, with six checks and one verdict. The card and the inbox row say the verdict.
  • A note on a call goes to the reviser with Request changes. With something written, Approve becomes Approve with edits.
  • An answered gate still shows its summary as it was shown.

Evidence, from the laptop

  • The journey ui/e2e/proposal-summary.spec.ts reads a proposal gate at 390 px and sends a note back. It failed at the missing Review button before an answered gate could be opened again.
  • test_a_plan_review_carries_no_summary_though_its_worktree_holds_one_change failed first: a plan review would have been given a summary.
  • Run 195's own documents, read by the new code: 8 parts, 65 requirements, 15 calls, 7 risks, six checks passed. That gate was 11,720 words as a diff.
  • The owner answered a simulated thorough run's gate in a browser, with a note and Approve with edits.
  • ./tools/test.sh passed in 52 s, and the smoke runs 7 of 7.

On production since 2026-11-14 (commit 1d512bf, database at schema 19). An old gate, which holds no summary, opens as it did before. The first summary will come with the next thorough or git-flow run.

Known, and not changed

  • At run 195's size a 390 by 844 phone shows 461 px of the summary at a time, because the console's own bars take 383 px.
  • The words box is not kept across a reload. The notes on calls are.
Shipped in pull request #539 and archived in #540. **What shipped** - The proposal gate opens on a summary assembled from the change's own documents, with six checks and one verdict. The card and the inbox row say the verdict. - A note on a call goes to the reviser with Request changes. With something written, Approve becomes Approve with edits. - An answered gate still shows its summary as it was shown. **Evidence, from the laptop** - The journey `ui/e2e/proposal-summary.spec.ts` reads a proposal gate at 390 px and sends a note back. It failed at the missing Review button before an answered gate could be opened again. - `test_a_plan_review_carries_no_summary_though_its_worktree_holds_one_change` failed first: a plan review would have been given a summary. - Run 195's own documents, read by the new code: 8 parts, 65 requirements, 15 calls, 7 risks, six checks passed. That gate was 11,720 words as a diff. - The owner answered a simulated `thorough` run's gate in a browser, with a note and Approve with edits. - `./tools/test.sh` passed in 52 s, and the smoke runs 7 of 7. **On production** since 2026-11-14 (commit 1d512bf, database at schema 19). An old gate, which holds no summary, opens as it did before. The first summary will come with the next `thorough` or `git-flow` run. **Known, and not changed** - At run 195's size a 390 by 844 phone shows 461 px of the summary at a time, because the console's own bars take 383 px. - The words box is not kept across a reload. The notes on calls are.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid#537
No description provided.