Proposal gate: a summary and six checks in place of the diff (#537) #539

Merged
cmoriarty merged 3 commits from claude/proposal-summary-537 into main 2026-11-14 12:41:02 -05:00
Owner

Slice 1 of #26, for #537. The proposal gate opens on a summary of the change in place of its diff.

  • What the gate shows: what Braid understood, what it will build, the calls it made, what is left out, the risks, and the documents with their reading time. Scripts read all of it from the change's own files. No model writes it and no step is added to a run.
  • Six checks, one verdict: Valid, Complete, Existing behaviour, Reviewed, Size, Clear of other work. The card and the inbox row say the verdict.
  • Notes: a note on a call goes to the reviser with Request changes. With something written, Approve becomes Approve with edits.
  • After the answer: the step's Review still shows the summary as it was shown.
  • Only where the change is shown: a plan review is a review gate too, and gets no summary.
  • Kept on the gate: gate.evidence, added by migration 19.

Tests: a new journey reads a proposal gate at 390 px from the inbox to the answer, sends a note with Request changes, and opens the answered gate again after a reload. It failed on the build before an answered gate could be opened again, at the missing Review button. 26 backend tests cover the reader and the gate, among them a plan review that carries no summary, which failed first. ./tools/test.sh passed in 52 s and the smoke runs passed 7 of 7.

Run 195's own documents, read by this code on the laptop, give 8 parts, 65 requirements, 15 calls, 7 risks and six passed checks. That gate was 11,720 words as a diff.

Checked in a real browser on the seeded state at 390 px and 1440 px. The fixture has no engine, so in the last picture of each set the step still reads "waiting on you" after its answer.

At 390 px: the summary, a look opened, a note written, the answers with something to send, a document, and the gate after its answer.

The summary at 390 px A look opened A note written on a call The answers with something to send A document opened from the summary The gate after its answer

At 1440 px: the summary, a look opened, a note written with the answers beside it, Files, and the gate after its answer.

The summary at 1440 px

A look opened

A note written, the answers beside it

Files

The gate after its answer

🤖 Generated with Claude Code

Slice 1 of #26, for #537. The proposal gate opens on a summary of the change in place of its diff. - **What the gate shows:** what Braid understood, what it will build, the calls it made, what is left out, the risks, and the documents with their reading time. Scripts read all of it from the change's own files. No model writes it and no step is added to a run. - **Six checks, one verdict:** Valid, Complete, Existing behaviour, Reviewed, Size, Clear of other work. The card and the inbox row say the verdict. - **Notes:** a note on a call goes to the reviser with Request changes. With something written, Approve becomes Approve with edits. - **After the answer:** the step's Review still shows the summary as it was shown. - **Only where the change is shown:** a plan review is a review gate too, and gets no summary. - **Kept on the gate:** `gate.evidence`, added by migration 19. Tests: a new journey reads a proposal gate at 390 px from the inbox to the answer, sends a note with Request changes, and opens the answered gate again after a reload. It failed on the build before an answered gate could be opened again, at the missing Review button. 26 backend tests cover the reader and the gate, among them a plan review that carries no summary, which failed first. `./tools/test.sh` passed in 52 s and the smoke runs passed 7 of 7. Run 195's own documents, read by this code on the laptop, give 8 parts, 65 requirements, 15 calls, 7 risks and six passed checks. That gate was 11,720 words as a diff. Checked in a real browser on the seeded state at 390 px and 1440 px. The fixture has no engine, so in the last picture of each set the step still reads "waiting on you" after its answer. **At 390 px:** the summary, a look opened, a note written, the answers with something to send, a document, and the gate after its answer. <img src="/attachments/00a1114f-81cf-4bed-98a8-b5a4ef70d79a" width="270" alt="The summary at 390 px"> <img src="/attachments/8c69879d-d12f-48bb-9258-d8d9936150f5" width="270" alt="A look opened"> <img src="/attachments/84b19821-7472-4c64-84a5-7af96af440bb" width="270" alt="A note written on a call"> <img src="/attachments/b075cfd3-be20-43a0-a8a8-93b35d3316d6" width="270" alt="The answers with something to send"> <img src="/attachments/f15edfd9-bc05-414b-b5d4-a5a2436511d1" width="270" alt="A document opened from the summary"> <img src="/attachments/d84dc140-2f0a-4d68-bc3d-762f5f321d82" width="270" alt="The gate after its answer"> **At 1440 px:** the summary, a look opened, a note written with the answers beside it, Files, and the gate after its answer. ![The summary at 1440 px](/attachments/60f923c5-26d3-45be-b74d-849b52da6bfa) ![A look opened](/attachments/897b3d26-bf57-49e9-a6bf-10704dce2461) ![A note written, the answers beside it](/attachments/c4f70c3e-2a74-4dff-bb3e-86ebc2bc910e) ![Files](/attachments/a9cb2d3d-4260-4313-88b4-dbfe0e65ab0a) ![The gate after its answer](/attachments/ac61a552-6a1c-42cc-bd13-8d70543c69cb) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Proposal gate: a summary and six checks in place of the diff (#537)
Some checks failed
test / suite (pull_request) Has been cancelled
76c63c3c57
- When a review gate that shows the change opens, Braid assembles a summary from the
  change's own documents and keeps it on the gate: what it understood, what it will build,
  the calls it made, what is left out, the risks, and six checks with one verdict. No model
  writes it and no step is added.
- The Review lens opens on the summary, on a phone and on a desktop. The card and the inbox
  row say the verdict.
- A note on a call goes to the reviser with Request changes. With something written, Approve
  becomes Approve with edits.
- An answered gate still shows the summary as it was shown, read from the step's record.
- A plan review carries no summary. Migration 19 adds the gate's evidence.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
chore(openspec): tick the screenshots task of proposal-summary-537 (#537)
All checks were successful
test / suite (pull_request) Successful in 1m40s
a262c534f0
The eleven screenshots are on pull request 539.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cmoriarty/braid!539
No description provided.